2024-02-15 09:46:39

by Maulik Shah (mkshah)

Subject: [PATCH] soc: qcom: qcom_stats: Add DSPs and apss subsystem stats

Add SMEM items for compute, general purpose DSPs and application processor
subsystem stats.

Signed-off-by: Maulik Shah <[email protected]>
---
drivers/soc/qcom/qcom_stats.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
index 0216fc24f2ca..c429d5154aae 100644
--- a/drivers/soc/qcom/qcom_stats.c
+++ b/drivers/soc/qcom/qcom_stats.c
@@ -35,11 +35,15 @@ static const struct subsystem_data subsystems[] = {
{ "wpss", 605, 13 },
{ "adsp", 606, 2 },
{ "cdsp", 607, 5 },
+ { "cdsp1", 607, 12 },
+ { "gpdsp0", 607, 17 },
+ { "gpdsp1", 607, 18 },
{ "slpi", 608, 3 },
{ "gpu", 609, 0 },
{ "display", 610, 0 },
{ "adsp_island", 613, 2 },
{ "slpi_island", 613, 3 },
+ { "apss", 631, QCOM_SMEM_HOST_ANY },
};

struct stats_config {

---
base-commit: 943b9f0ab2cfbaea148dd6ac279957eb08b96904
change-id: 20240215-qcom_stats-442d21d964c8

Best regards,
--
Maulik Shah <[email protected]>

2024-02-15 10:32:15

by Konrad Dybcio

Subject: Re: [PATCH] soc: qcom: qcom_stats: Add DSPs and apss subsystem stats

On 15.02.2024 10:23, Maulik Shah wrote:
> Add SMEM items for compute, general purpose DSPs and application processor
> subsystem stats.
>
> Signed-off-by: Maulik Shah <[email protected]>
> ---
> drivers/soc/qcom/qcom_stats.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
> index 0216fc24f2ca..c429d5154aae 100644
> --- a/drivers/soc/qcom/qcom_stats.c
> +++ b/drivers/soc/qcom/qcom_stats.c
> @@ -35,11 +35,15 @@ static const struct subsystem_data subsystems[] = {
> { "wpss", 605, 13 },
> { "adsp", 606, 2 },
> { "cdsp", 607, 5 },
> + { "cdsp1", 607, 12 },
> + { "gpdsp0", 607, 17 },
> + { "gpdsp1", 607, 18 },
> { "slpi", 608, 3 },
> { "gpu", 609, 0 },
> { "display", 610, 0 },
> { "adsp_island", 613, 2 },
> { "slpi_island", 613, 3 },
> + { "apss", 631, QCOM_SMEM_HOST_ANY },

Reviewed-by: Konrad Dybcio <[email protected]>

Although, giving it a spin on 8280, it's not there.. It is there
on 8450, but the reported count seems to coincide with cpuidle..
roughly min{/sys/bus/cpu/devices/cpu*/cpuidle/state0/usage).

Konrad

2024-02-15 11:32:10

by Maulik Shah (mkshah)

Subject: Re: [PATCH] soc: qcom: qcom_stats: Add DSPs and apss subsystem stats

On 2/15/2024 3:24 PM, Konrad Dybcio wrote:
> On 15.02.2024 10:23, Maulik Shah wrote:
>> Add SMEM items for compute, general purpose DSPs and application processor
>> subsystem stats.
>>
>> Signed-off-by: Maulik Shah <[email protected]>
>> ---
>> drivers/soc/qcom/qcom_stats.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
>> index 0216fc24f2ca..c429d5154aae 100644
>> --- a/drivers/soc/qcom/qcom_stats.c
>> +++ b/drivers/soc/qcom/qcom_stats.c
>> @@ -35,11 +35,15 @@ static const struct subsystem_data subsystems[] = {
>> { "wpss", 605, 13 },
>> { "adsp", 606, 2 },
>> { "cdsp", 607, 5 },
>> + { "cdsp1", 607, 12 },
>> + { "gpdsp0", 607, 17 },
>> + { "gpdsp1", 607, 18 },
>> { "slpi", 608, 3 },
>> { "gpu", 609, 0 },
>> { "display", 610, 0 },
>> { "adsp_island", 613, 2 },
>> { "slpi_island", 613, 3 },
>> + { "apss", 631, QCOM_SMEM_HOST_ANY },
>
> Reviewed-by: Konrad Dybcio <[email protected]>
>
Thanks for the review.

> Although, giving it a spin on 8280, it's not there.. It is there
> on 8450, but the reported count seems to coincide with cpuidle..
> roughly min{/sys/bus/cpu/devices/cpu*/cpuidle/state0/usage).
>
> Konrad

yes apss stats should be available from sm8450 onward and count should
(not necessarily) coincide with
/sys/kernel/debug/pm_genpd/power-domain-cluster/idle_states, s1 usage
count on sm8450.

DSP stats for gdsp0/gdsp1/cdsp1 are available in sa8775p.

Thanks,
Maulik

2024-03-19 02:54:31

by Bjorn Andersson

Subject: Re: [PATCH] soc: qcom: qcom_stats: Add DSPs and apss subsystem stats

On Thu, 15 Feb 2024 14:53:50 +0530, Maulik Shah wrote:
> Add SMEM items for compute, general purpose DSPs and application processor
> subsystem stats.
>
>

Applied, thanks!

[1/1] soc: qcom: qcom_stats: Add DSPs and apss subsystem stats
commit: f8627c303fd34ab70ff6fd8a1048ac11035b7fd6

Best regards,
--
Bjorn Andersson <[email protected]>