2023-09-05 16:19:59

by Shinichiro Kawasaki

[permalink] [raw]
Subject: Re: [PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code

On Aug 30, 2023 / 01:19, Shinichiro Kawasaki wrote:
[...]
> Thank you for confirmation. It's good that we clarified this confusing point :)
> I will revert the 26664dff17b6 ("Do not suppress any shellcheck warnings") to
> suppress SC2119.

FYI, the commit 3d1c0fe2677d did the revert.

>
> Later on, I'll create a clean-up-patch for SC2119 which will revert relevant
> commits 852996fea4f1 and 45b203cce8b (partially for the latter).

Also, I've applied the commit 2045e8d3df86 for the clean-up above. It should be
all good now.