2023-09-27 06:41:40

by chenguohua

Subject: [PATCH] vidio: Clean up errors in serial.h

Fix the following errors reported by checkpatch:

ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: GuoHua Cheng <[email protected]>
---
include/linux/amba/clcd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/amba/clcd.h b/include/linux/amba/clcd.h
index b6e0cbeaf533..64df8235d9cc 100644
--- a/include/linux/amba/clcd.h
+++ b/include/linux/amba/clcd.h
@@ -244,7 +244,7 @@ static inline int clcdfb_check(struct clcd_fb *fb, struct fb_var_screeninfo *var
var->xres_virtual = var->xres = (var->xres + 15) & ~15;
var->yres_virtual = var->yres = (var->yres + 1) & ~1;

-#define CHECK(e,l,h) (var->e < l || var->e > h)
+#define CHECK(e, l, h) (var->e < l || var->e > h)
if (CHECK(right_margin, (5+1), 256) || /* back porch */
CHECK(left_margin, (5+1), 256) || /* front porch */
CHECK(hsync_len, (5+1), 256) ||
--
2.17.1

2023-09-27 11:44:09

by Greg Kroah-Hartman

Subject: Re: [PATCH] vidio: Clean up errors in serial.h

On Wed, Sep 27, 2023 at 02:32:23PM +0800, [email protected] wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: GuoHua Cheng <[email protected]>

Your subject line is very odd.

> ---
> include/linux/amba/clcd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/amba/clcd.h b/include/linux/amba/clcd.h
> index b6e0cbeaf533..64df8235d9cc 100644
> --- a/include/linux/amba/clcd.h
> +++ b/include/linux/amba/clcd.h
> @@ -244,7 +244,7 @@ static inline int clcdfb_check(struct clcd_fb *fb, struct fb_var_screeninfo *var
> var->xres_virtual = var->xres = (var->xres + 15) & ~15;
> var->yres_virtual = var->yres = (var->yres + 1) & ~1;
>
> -#define CHECK(e,l,h) (var->e < l || var->e > h)
> +#define CHECK(e, l, h) (var->e < l || var->e > h)

There is nothing wrong with the original code here, please do not run
checkpatch on code that is NOT in drivers/staging/ unless you get the
approval of the maintainer to do so.

thanks,

greg k-h