2023-11-15 22:27:38

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add mps mp5990 driver bindings

On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote:
> Add a device tree bindings for mp5990 device.
>
> Signed-off-by: Peter Yin <[email protected]>
> Acked-by: Conor Dooley <[email protected]>

What branch is this patch based on ? git fails to apply it.

Guenter


2023-11-17 03:21:16

by Peter Yin

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add mps mp5990 driver bindings



Guenter Roeck 於 11/16/23 06:27 寫道:
> On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote:
>> Add a device tree bindings for mp5990 device.
>>
>> Signed-off-by: Peter Yin <[email protected]>
>> Acked-by: Conor Dooley <[email protected]>
>
> What branch is this patch based on ? git fails to apply it.
>
> Guenter
I think I don't pull the last version. I can rebase it and push the new
version. Thanks for your feedback.

2023-11-17 04:17:45

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add mps mp5990 driver bindings

On Fri, Nov 17, 2023 at 11:18:47AM +0800, PeterYin wrote:
>
>
> Guenter Roeck 於 11/16/23 06:27 寫道:
> > On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote:
> > > Add a device tree bindings for mp5990 device.
> > >
> > > Signed-off-by: Peter Yin <[email protected]>
> > > Acked-by: Conor Dooley <[email protected]>
> >
> > What branch is this patch based on ? git fails to apply it.
> >
> > Guenter
> I think I don't pull the last version. I can rebase it and push the new
> version. Thanks for your feedback.

Question is: Last version of what ? Best would be if it was based
on mainline.

Thanks,
Guenter

2023-11-17 04:54:27

by Peter Yin

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add mps mp5990 driver bindings



Guenter Roeck 於 11/17/23 12:16 寫道:
> On Fri, Nov 17, 2023 at 11:18:47AM +0800, PeterYin wrote:
>>
>>
>> Guenter Roeck 於 11/16/23 06:27 寫道:
>>> On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote:
>>>> Add a device tree bindings for mp5990 device.
>>>>
>>>> Signed-off-by: Peter Yin <[email protected]>
>>>> Acked-by: Conor Dooley <[email protected]>
>>>
>>> What branch is this patch based on ? git fails to apply it.
>>>
>>> Guenter
>> I think I don't pull the last version. I can rebase it and push the new
>> version. Thanks for your feedback.
>
> Question is: Last version of what ? Best would be if it was based
> on mainline.
>
> Thanks,
> Guenter

It is base on Linux 6.5.4, OpenBMC Kernel tree
https://github.com/openbmc/linux/commit/2ba0babe7865cd5f4fac3d76ad15d9b6131bd283

I can regenerate it on mainline.

Thanks,
Peter.

2023-11-17 15:20:21

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add mps mp5990 driver bindings

On 11/16/23 20:52, PeterYin wrote:
>
>
> Guenter Roeck 於 11/17/23 12:16 寫道:
>> On Fri, Nov 17, 2023 at 11:18:47AM +0800, PeterYin wrote:
>>>
>>>
>>> Guenter Roeck 於 11/16/23 06:27 寫道:
>>>> On Mon, Nov 13, 2023 at 11:50:07PM +0800, Peter Yin wrote:
>>>>> Add a device tree bindings for mp5990 device.
>>>>>
>>>>> Signed-off-by: Peter Yin <[email protected]>
>>>>> Acked-by: Conor Dooley <[email protected]>
>>>>
>>>> What branch is this patch based on ? git fails to apply it.
>>>>
>>>> Guenter
>>> I think I don't pull the last version. I can rebase it and push the new
>>> version. Thanks for your feedback.
>>
>> Question is: Last version of what ? Best would be if it was based
>> on mainline.
>>
>> Thanks,
>> Guenter
>
> It is base on Linux 6.5.4, OpenBMC Kernel tree
> https://github.com/openbmc/linux/commit/2ba0babe7865cd5f4fac3d76ad15d9b6131bd283
>
> I can regenerate it on mainline.
>

No need; git was able to apply it after I aded the openbmc tree as remote.
It would be great if you can base future patches on Linux mainline.

Thanks,
Guenter