2023-01-09 22:43:42

by Bjorn Andersson

Subject: [PATCH] rpmsg: glink: Include types in qcom_glink_native.h

Ensure that the used data types are available in qcom_glink_native.h, to
silence LSP warnings.

Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/rpmsg/qcom_glink_native.h | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/rpmsg/qcom_glink_native.h b/drivers/rpmsg/qcom_glink_native.h
index 624184fc458e..e9a8671616c7 100644
--- a/drivers/rpmsg/qcom_glink_native.h
+++ b/drivers/rpmsg/qcom_glink_native.h
@@ -6,6 +6,8 @@
#ifndef __QCOM_GLINK_NATIVE_H__
#define __QCOM_GLINK_NATIVE_H__

+#include <linux/types.h>
+
#define GLINK_FEATURE_INTENT_REUSE BIT(0)
#define GLINK_FEATURE_MIGRATION BIT(1)
#define GLINK_FEATURE_TRACER_PKT BIT(2)
@@ -24,6 +26,7 @@ struct qcom_glink_pipe {
const void *data, size_t dlen);
};

+struct device;
struct qcom_glink;

struct qcom_glink *qcom_glink_native_probe(struct device *dev,
--
2.37.3

2023-01-18 01:22:23

by Chris Lew

Subject: Re: [PATCH] rpmsg: glink: Include types in qcom_glink_native.h

On 1/9/2023 2:37 PM, Bjorn Andersson wrote:
> Ensure that the used data types are available in qcom_glink_native.h, to
> silence LSP warnings.
>
> Signed-off-by: Bjorn Andersson <[email protected]>

Reviewed-by: Chris Lew <[email protected]>

> ---
> drivers/rpmsg/qcom_glink_native.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/rpmsg/qcom_glink_native.h b/drivers/rpmsg/qcom_glink_native.h
> index 624184fc458e..e9a8671616c7 100644
> --- a/drivers/rpmsg/qcom_glink_native.h
> +++ b/drivers/rpmsg/qcom_glink_native.h
> @@ -6,6 +6,8 @@
> #ifndef __QCOM_GLINK_NATIVE_H__
> #define __QCOM_GLINK_NATIVE_H__
>
> +#include <linux/types.h>
> +
> #define GLINK_FEATURE_INTENT_REUSE BIT(0)
> #define GLINK_FEATURE_MIGRATION BIT(1)
> #define GLINK_FEATURE_TRACER_PKT BIT(2)
> @@ -24,6 +26,7 @@ struct qcom_glink_pipe {
> const void *data, size_t dlen);
> };
>
> +struct device;
> struct qcom_glink;
>
> struct qcom_glink *qcom_glink_native_probe(struct device *dev,
>

2023-01-18 22:47:59

by Bjorn Andersson

Subject: Re: [PATCH] rpmsg: glink: Include types in qcom_glink_native.h

On Mon, 9 Jan 2023 14:37:45 -0800, Bjorn Andersson wrote:
> Ensure that the used data types are available in qcom_glink_native.h, to
> silence LSP warnings.
>
>

Applied, thanks!

[1/1] rpmsg: glink: Include types in qcom_glink_native.h
commit: f014eda5d5923a1d85f29dc7467cd90e9775cbfd

Best regards,
--
Bjorn Andersson <[email protected]>