2024-05-31 23:38:04

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH] net: ethtool: remove unused struct 'cable_test_tdr_req_info'

From: "Dr. David Alan Gilbert" <[email protected]>

'cable_test_tdr_req_info' is unused since the original
commit f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to
configured").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
net/ethtool/cabletest.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c
index 06a151165c31..f6f136ec7ddf 100644
--- a/net/ethtool/cabletest.c
+++ b/net/ethtool/cabletest.c
@@ -207,10 +207,6 @@ int ethnl_cable_test_fault_length(struct phy_device *phydev, u8 pair, u32 cm)
}
EXPORT_SYMBOL_GPL(ethnl_cable_test_fault_length);

-struct cable_test_tdr_req_info {
- struct ethnl_req_info base;
-};
-
static const struct nla_policy cable_test_tdr_act_cfg_policy[] = {
[ETHTOOL_A_CABLE_TEST_TDR_CFG_FIRST] = { .type = NLA_U32 },
[ETHTOOL_A_CABLE_TEST_TDR_CFG_LAST] = { .type = NLA_U32 },
--
2.45.1



2024-06-02 17:46:50

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH] net: ethtool: remove unused struct 'cable_test_tdr_req_info'

On Sat, Jun 01, 2024 at 12:30:06AM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'cable_test_tdr_req_info' is unused since the original
> commit f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to
> configured").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2024-06-05 09:44:25

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: ethtool: remove unused struct 'cable_test_tdr_req_info'

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Sat, 1 Jun 2024 00:30:06 +0100 you wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'cable_test_tdr_req_info' is unused since the original
> commit f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to
> configured").
>
> Remove it.
>
> [...]

Here is the summary with links:
- net: ethtool: remove unused struct 'cable_test_tdr_req_info'
https://git.kernel.org/netdev/net-next/c/a23b0034e934

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html