2020-10-05 16:16:23

by Mike Rapoport

[permalink] [raw]
Subject: [PATCH] ARC: SMP: fix typo and use "come up" instead of "comeup"

From: Mike Rapoport <[email protected]>

When a secondary CPU fails to come up, there is a missing space in the
log:

Timeout: CPU1 FAILED to comeup !!!

Fix it.

Signed-off-by: Mike Rapoport <[email protected]>
---
arch/arc/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c
index eca35e02ce06..52906d314537 100644
--- a/arch/arc/kernel/smp.c
+++ b/arch/arc/kernel/smp.c
@@ -226,7 +226,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
}

if (!cpu_online(cpu)) {
- pr_info("Timeout: CPU%u FAILED to comeup !!!\n", cpu);
+ pr_info("Timeout: CPU%u FAILED to come up !!!\n", cpu);
return -1;
}

--
2.25.4


2020-10-06 04:08:34

by Vineet Gupta

[permalink] [raw]
Subject: Re: [PATCH] ARC: SMP: fix typo and use "come up" instead of "comeup"

On 10/5/20 9:12 AM, Mike Rapoport wrote:
> From: Mike Rapoport <[email protected]>
>
> When a secondary CPU fails to come up, there is a missing space in the
> log:
>
> Timeout: CPU1 FAILED to comeup !!!
>
> Fix it.
>
> Signed-off-by: Mike Rapoport <[email protected]>

Thx for the fix Mike. Added to for-curr.
-Vineet

> ---
> arch/arc/kernel/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c
> index eca35e02ce06..52906d314537 100644
> --- a/arch/arc/kernel/smp.c
> +++ b/arch/arc/kernel/smp.c
> @@ -226,7 +226,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
> }
>
> if (!cpu_online(cpu)) {
> - pr_info("Timeout: CPU%u FAILED to comeup !!!\n", cpu);
> + pr_info("Timeout: CPU%u FAILED to come up !!!\n", cpu);
> return -1;
> }
>
>