2020-10-31 01:38:19

by Zou Wei

Subject: [PATCH -next v2] usb: Mark sync_all_pins() with static keyword

Fix the following sparse warning:

./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?

The sync_all_pins has only call site within brcmstb-usb-pinmap.c
Mark it static as suggested.

Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
v2:
- Make title more precise.
- Shorten the warning path.
- Add period.
drivers/usb/misc/brcmstb-usb-pinmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
index 02144c3..cc9618d 100644
--- a/drivers/usb/misc/brcmstb-usb-pinmap.c
+++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
@@ -216,7 +216,7 @@ static int parse_pins(struct device *dev, struct device_node *dn,
return 0;
}

-void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
+static void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
{
struct out_pin *pout;
struct in_pin *pin;
--
2.6.2

2020-10-31 01:56:27

by Florian Fainelli

Subject: Re: [PATCH -next v2] usb: Mark sync_all_pins() with static keyword

On 10/30/2020 6:48 PM, Zou Wei wrote:
> Fix the following sparse warning:
>
> ./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
>
> The sync_all_pins has only call site within brcmstb-usb-pinmap.c
> Mark it static as suggested.
>
> Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")

Not sure if the Fixes: tag is entirely appropriate here, but sure, why not.

> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian