2017-07-06 17:52:23

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] tpm: tpm_tis: constify acpi_device_id.

acpi_device_id are not supposed to change at runtime. All functions
working with acpi_device_id provided by <acpi/acpi_bus.h> work with
const acpi_device_id. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
2758 1089 10 3857 f11 drivers/char/tpm/tpm_tis.o

File size After adding 'const':
text data bss dec hex filename
2854 993 10 3857 f11 drivers/char/tpm/tpm_tis.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/char/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index c7e1384..a66e03e 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -297,7 +297,7 @@ static int tpm_tis_acpi_remove(struct acpi_device *dev)
return 0;
}

-static struct acpi_device_id tpm_acpi_tbl[] = {
+static const struct acpi_device_id tpm_acpi_tbl[] = {
{"MSFT0101", 0}, /* TPM 2.0 */
/* Add new here */
{"", 0}, /* User Specified */
--
2.7.4