2023-01-09 12:32:49

by Neil Armstrong

Subject: [PATCH v3] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles

Document the compatibles used to describe the Bandwidth Monitors
present on the SM8550 platform.

A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
bandwidth monitoring.

This is described by adding "llcc" and "cpu" into the compatible
strings to differentiate the BWMON IPs.

Signed-off-by: Neil Armstrong <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
--
---
Changes in v3:
- rebased on v6.2-rc1
- Link to v2: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v2-0-20c555e3ba5d@linaro.org

Changes in v2:
- Reworded commit message
- Added Reviewed-by from Krzysztof
- Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
---
Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
index 0c720dbde36e..12a0d3ecbabb 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
@@ -27,11 +27,13 @@ properties:
- qcom,sc7280-cpu-bwmon
- qcom,sc8280xp-cpu-bwmon
- qcom,sdm845-bwmon
+ - qcom,sm8550-cpu-bwmon
- const: qcom,msm8998-bwmon
- const: qcom,msm8998-bwmon # BWMON v4
- items:
- enum:
- qcom,sc8280xp-llcc-bwmon
+ - qcom,sm8550-llcc-bwmon
- const: qcom,sc7280-llcc-bwmon
- const: qcom,sc7280-llcc-bwmon # BWMON v5
- const: qcom,sdm845-llcc-bwmon # BWMON v5

---
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
change-id: 20221114-narmstrong-sm8550-upstream-bwmon-a7c6227fab6d

Best regards,
--
Neil Armstrong <[email protected]>

2023-01-18 15:20:52

by Neil Armstrong

Subject: Re: [PATCH v3] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles

Hi Georgi,

On 09/01/2023 13:11, Neil Armstrong wrote:
> Document the compatibles used to describe the Bandwidth Monitors
> present on the SM8550 platform.
>
> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
> bandwidth monitoring.
>
> This is described by adding "llcc" and "cpu" into the compatible
> strings to differentiate the BWMON IPs.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Gentle ping,
Neil

> ---
> --
> ---
> Changes in v3:
> - rebased on v6.2-rc1
> - Link to v2: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v2-0-20c555e3ba5d@linaro.org
>
> Changes in v2:
> - Reworded commit message
> - Added Reviewed-by from Krzysztof
> - Link to v1: https://lore.kernel.org/r/20221114-narmstrong-sm8550-upstream-bwmon-v1-0-b6dd08927f35@linaro.org
> ---
> Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> index 0c720dbde36e..12a0d3ecbabb 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8998-bwmon.yaml
> @@ -27,11 +27,13 @@ properties:
> - qcom,sc7280-cpu-bwmon
> - qcom,sc8280xp-cpu-bwmon
> - qcom,sdm845-bwmon
> + - qcom,sm8550-cpu-bwmon
> - const: qcom,msm8998-bwmon
> - const: qcom,msm8998-bwmon # BWMON v4
> - items:
> - enum:
> - qcom,sc8280xp-llcc-bwmon
> + - qcom,sm8550-llcc-bwmon
> - const: qcom,sc7280-llcc-bwmon
> - const: qcom,sc7280-llcc-bwmon # BWMON v5
> - const: qcom,sdm845-llcc-bwmon # BWMON v5
>
> ---
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> change-id: 20221114-narmstrong-sm8550-upstream-bwmon-a7c6227fab6d
>
> Best regards,

2023-01-20 10:07:31

by Georgi Djakov

Subject: Re: [PATCH v3] dt-bindings: interconnect: qcom-bwmon: document SM8550 compatibles

On 18.01.23 17:05, Neil Armstrong wrote:
> Hi Georgi,
>
> On 09/01/2023 13:11, Neil Armstrong wrote:
>> Document the compatibles used to describe the Bandwidth Monitors
>> present on the SM8550 platform.
>>
>> A BWMON v4 IP monitors the CPU bandwidth, and a v5 does the LLCC
>> bandwidth monitoring.
>>
>> This is described by adding "llcc" and "cpu" into the compatible
>> strings to differentiate the BWMON IPs.
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> Gentle ping,
> Neil

Thanks Neil! Applied and in linux-next already.

BR,
Georgi