2018-05-12 17:09:47

by Christophe JAILLET

Subject: [PATCH] net/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/vport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vport.c b/drivers/net/ethernet/mellanox/mlx5/core/vport.c
index 177e076b8d17..49968a4db758 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/vport.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/vport.c
@@ -511,7 +511,7 @@ int mlx5_query_nic_vport_system_image_guid(struct mlx5_core_dev *mdev,
*system_image_guid = MLX5_GET64(query_nic_vport_context_out, out,
nic_vport_context.system_image_guid);

- kfree(out);
+ kvfree(out);

return 0;
}
--
2.17.0

2018-05-14 18:57:54

by David Miller

Subject: Re: [PATCH] net/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

From: Christophe JAILLET <[email protected]>
Date: Sat, 12 May 2018 19:09:25 +0200

> 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Saeed, I assume I will see this in one of your forthcoming pull
requests.

Thanks.

2018-05-14 19:38:17

by Christophe JAILLET

Subject: Re: [PATCH] net/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

Le 14/05/2018 à 20:56, David Miller a écrit :
> From: Christophe JAILLET <[email protected]>
> Date: Sat, 12 May 2018 19:09:25 +0200
>
>> 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it.
>>
>> Signed-off-by: Christophe JAILLET <[email protected]>
>
> Saeed, I assume I will see this in one of your forthcoming pull
> requests.
>
> Thanks.
>

I've send a v2 with additional 'kvfree()' fixes.

CJ

2018-05-14 22:38:20

by Saeed Mahameed

Subject: Re: [PATCH] net/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

On Mon, May 14, 2018 at 11:56 AM, David Miller <[email protected]> wrote:
> From: Christophe JAILLET <[email protected]>
> Date: Sat, 12 May 2018 19:09:25 +0200
>
>> 'out' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it.
>>
>> Signed-off-by: Christophe JAILLET <[email protected]>
>
> Saeed, I assume I will see this in one of your forthcoming pull
> requests.
>
> Thanks.

In case this is for net-next, I will apply v3 to mlx5-next once
Christophe adds the "Fixes" tags according to Eric's request.
if it is for net (RC) then you can go ahead and apply v3 to net branch.

Thanks,
Saeed.