2023-11-15 11:26:30

by Jarkko Nikula

[permalink] [raw]
Subject: Re: [PATCH v3 03/25] i2c: designware: Fix reset call order in dw_i2c_plat_probe()

On 11/10/23 20:11, Andy Shevchenko wrote:
> We should not mix managed calls with non-managed. This will break
> the calls order at the error path and ->remove() stages. Fix this
> by wrapping reset control to become managed one.
>
> With that start checking the rerurn code from reset_control_deassert()
> as it may fail and calling assertion in that scenario is not always
> a good idea.
>
> Fixes: ab809fd81fde ("i2c: designware: add reset interface")
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---

Again, was above commit so broken that this patch qualifies a Fixes tag?