2022-07-13 14:58:56

by Srinivasa Rao Mandadapu

Subject: [PATCH v2] soundwire: qcom: Update error prints to debug prints

Update error prints to debug prints to avoid redundant logging in kernel
boot time, as these prints are informative prints in irq handler.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
Reviewed-by: Andrew Halaney <[email protected]>
---
Changes since v1:
-- Remove redundant __func__ argument.
-- Replace dev_dbg with dev_dbg_ratelimited.

drivers/soundwire/qcom.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 9df970e..976ae75 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
break;
case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
- dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
- __func__);
+ dev_dbg_ratelimited(swrm->dev, "SWR new slave attached\n");
swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status);
if (swrm->slave_status == slave_status) {
- dev_err(swrm->dev, "Slave status not changed %x\n",
+ dev_dbg(swrm->dev, "Slave status not changed %x\n",
slave_status);
} else {
qcom_swrm_get_device_status(swrm);
--
2.7.4

2022-07-13 15:23:19

by Pierre-Louis Bossart

Subject: Re: [PATCH v2] soundwire: qcom: Update error prints to debug prints

On 7/13/22 09:54, Srinivasa Rao Mandadapu wrote:
> Update error prints to debug prints to avoid redundant logging in kernel
> boot time, as these prints are informative prints in irq handler.
>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> Reviewed-by: Andrew Halaney <[email protected]>

Reviewed-by: Pierre-Louis Bossart <[email protected]>

> ---
> Changes since v1:
> -- Remove redundant __func__ argument.
> -- Replace dev_dbg with dev_dbg_ratelimited.
>
> drivers/soundwire/qcom.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 9df970e..976ae75 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
> break;
> case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
> case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
> - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
> - __func__);
> + dev_dbg_ratelimited(swrm->dev, "SWR new slave attached\n");
> swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status);
> if (swrm->slave_status == slave_status) {
> - dev_err(swrm->dev, "Slave status not changed %x\n",
> + dev_dbg(swrm->dev, "Slave status not changed %x\n",
> slave_status);
> } else {
> qcom_swrm_get_device_status(swrm);

2022-08-23 19:23:00

by Vinod Koul

Subject: Re: [PATCH v2] soundwire: qcom: Update error prints to debug prints

On 13-07-22, 20:24, Srinivasa Rao Mandadapu wrote:
> Update error prints to debug prints to avoid redundant logging in kernel
> boot time, as these prints are informative prints in irq handler.

Applied, thanks

--
~Vinod