Change SNOR_HWCPAS_READ_OCTAL to SNOR_HWCAPS_READ_OCTAL.
Signed-off-by: Bean Huo <[email protected]>
---
include/linux/mtd/spi-nor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
index 2353af8..b3d360b 100644
--- a/include/linux/mtd/spi-nor.h
+++ b/include/linux/mtd/spi-nor.h
@@ -487,7 +487,7 @@ struct spi_nor_hwcaps {
#define SNOR_HWCAPS_READ_4_4_4 BIT(9)
#define SNOR_HWCAPS_READ_1_4_4_DTR BIT(10)
-#define SNOR_HWCPAS_READ_OCTAL GENMASK(14, 11)
+#define SNOR_HWCAPS_READ_OCTAL GENMASK(14, 11)
#define SNOR_HWCAPS_READ_1_1_8 BIT(11)
#define SNOR_HWCAPS_READ_1_8_8 BIT(12)
#define SNOR_HWCAPS_READ_8_8_8 BIT(13)
--
2.7.4
On 02/08/2019 04:23 PM, Bean Huo (beanhuo) wrote:
> Change SNOR_HWCPAS_READ_OCTAL to SNOR_HWCAPS_READ_OCTAL.
>
> Signed-off-by: Bean Huo <[email protected]>
$ ./scripts/checkpatch.pl --strict
v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo (beanhuo)
<[email protected]>'
There are scripts that check that the author/committer has its SoB, depending on
how strict the check is, it might complaint that SoB an author/committer do not
match, so please change gitconfig to make them match.
> ---
> include/linux/mtd/spi-nor.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index 2353af8..b3d360b 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -487,7 +487,7 @@ struct spi_nor_hwcaps {
> #define SNOR_HWCAPS_READ_4_4_4 BIT(9)
> #define SNOR_HWCAPS_READ_1_4_4_DTR BIT(10)
>
> -#define SNOR_HWCPAS_READ_OCTAL GENMASK(14, 11)
> +#define SNOR_HWCAPS_READ_OCTAL GENMASK(14, 11)
> #define SNOR_HWCAPS_READ_1_1_8 BIT(11)
> #define SNOR_HWCAPS_READ_1_8_8 BIT(12)
> #define SNOR_HWCAPS_READ_8_8_8 BIT(13)
>
Hi, Tudor
./scripts/checkpatch.pl --strict 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
total: 0 errors, 0 warnings, 0 checks, 8 lines checked
0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch has no obvious style problems and is ready for submission.
>
>On 02/08/2019 04:23 PM, Bean Huo (beanhuo) wrote:
>> Change SNOR_HWCPAS_READ_OCTAL to SNOR_HWCAPS_READ_OCTAL.
>>
>> Signed-off-by: Bean Huo <[email protected]>
>
>$ ./scripts/checkpatch.pl --strict
>v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo
>(beanhuo) <[email protected]>'
>
'Bean Huo (beanhuo) <[email protected]>' is wrong.
If you prefer to 'Bean Huo (beanhuo) <[email protected]>, would you please change that.
//Bean
Hi, Tutor
>$ ./scripts/checkpatch.pl --strict
>v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo
>(beanhuo) <[email protected]>'
>
I think, this is because of our email system, it always adds '(xxx)' between user name
and email address.
If you are convenient, please help fix since it is not such hug change.
Thanks,
//Bean
Hi, Bean,
On 02/08/2019 05:27 PM, Bean Huo (beanhuo) wrote:
> Hi, Tutor
>
>> $ ./scripts/checkpatch.pl --strict
>> v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>> WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo
>> (beanhuo) <[email protected]>'
>>
> I think, this is because of our email system, it always adds '(xxx)' between user name
> and email address.
> If you are convenient, please help fix since it is not such hug change.
I'm on a funny email server too, it keeps overwriting my email header "from
field". I have a workaround that might work for you too. Here's part of my
.gitconfig:
[user]
name = Tudor Ambarus
email = [email protected]
[sendemail]
from = Tudor X Ambarus <[email protected]>
Because my [sendemail] from field is different than my [user] name and email,
git send-email will add in the body of the patch the [user] name and email:
From: Tudor Ambarus <[email protected]>
When the patch is applied, it takes the author name from the patch body. Even if
the server overwrites the from field from the header, it will be ignored.
Let me know if this works for you.
ta
Hi, Tutor
Thanks. unfortunately, it doesn't work on my side. Problem is on our email server side, not my local setting.
I followed your configuration, then git-email failed.
Please just change my S-o-b to 'Bean Huo (beanhuo) <[email protected]>' in my patch to please checkpacth.pl. It is not huge change.
Thanks,
>
>On 02/08/2019 05:27 PM, Bean Huo (beanhuo) wrote:
>> Hi, Tutor
>>
>>> $ ./scripts/checkpatch.pl --strict
>>> v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>>> WARNING: Missing Signed-off-by: line by nominal patch author 'Bean
>>> Huo
>>> (beanhuo) <[email protected]>'
>>>
>> I think, this is because of our email system, it always adds '(xxx)'
>> between user name and email address.
>> If you are convenient, please help fix since it is not such hug change.
>
>I'm on a funny email server too, it keeps overwriting my email header "from field".
>I have a workaround that might work for you too. Here's part of my
>.gitconfig:
>
>[user]
> name = Tudor Ambarus
> email = [email protected] [sendemail]
> from = Tudor X Ambarus <[email protected]>
>
>Because my [sendemail] from field is different than my [user] name and email, git
>send-email will add in the body of the patch the [user] name and email:
>
>From: Tudor Ambarus <[email protected]>
>
>When the patch is applied, it takes the author name from the patch body. Even if
>the server overwrites the from field from the header, it will be ignored.
>
>Let me know if this works for you.
>ta
>______________________________________________________
>Linux MTD discussion mailing list
>http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi Bean,
On Fri, 8 Feb 2019 17:13:52 +0000
"Bean Huo (beanhuo)" <[email protected]> wrote:
> Hi, Tutor
> Thanks. unfortunately, it doesn't work on my side. Problem is on our email server side, not my local setting.
> I followed your configuration, then git-email failed.
Can you paste the output of git send-email and the [sendemail] section
of your .gitconfig so we can check.
It shouldn't fail, really, because the server shouldn't check the body
section of your email, and this is where the extra
From: First Last <[email protected]>
line is placed.
> Please just change my S-o-b to 'Bean Huo (beanhuo) <[email protected]>' in my patch to please checkpacth.pl. It is not huge change.
It's not a problem when an drive-by contributor posts a patch, but if
you don't patch it that means we'll have to do it manually every time
we apply one of your patch, so please find a solution.
Thanks,
Boris
Hi,Boris
I sent three times, seems last time is successful. would you check that is correct?
git send-email 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
To whom should the emails be sent (if anyone)? [email protected],[email protected],[email protected],[email protected]
Message-ID to be used as In-Reply-To for the first email (if any)?
(mbox) Adding cc: Bean Huo <[email protected]> from line 'From: Bean Huo <[email protected]>'
(body) Adding cc: Bean Huo <[email protected]> from line 'Signed-off-by: Bean Huo <[email protected]>'
From: Bean Huo <[email protected]>
To: [email protected],
[email protected],
[email protected],
[email protected]
Cc: Bean Huo <[email protected]>
Subject: [PATCH] mtd: spi-nor: Fix wrong abbreviation HWCPAS
Date: Fri, 8 Feb 2019 18:00:12 +0000
Message-Id: <[email protected]>
X-Mailer: git-send-email 2.17.1
The Cc list above has been expanded by additional
addresses found in the patch commit message. By default
send-email prompts before sending whenever this occurs.
This behavior is controlled by the sendemail.confirm
configuration setting.
For additional information, run 'git send-email --help'.
To retain the current behavior, but squelch this message,
run 'git config --global sendemail.confirm auto'.
Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
OK. Log says:
Sendmail: /usr/sbin/sendmail -i [email protected] [email protected] [email protected] [email protected] [email protected]
From: Bean Huo <[email protected]>
To: [email protected],
[email protected],
[email protected],
[email protected]
Cc: Bean Huo <[email protected]>
Subject: [RESEND PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS
Date: Fri, 8 Feb 2019 18:00:12 +0000
Message-Id: <[email protected]>
X-Mailer: git-send-email 2.17.1
Result: OK
>
>Hi Bean,
>
>On Fri, 8 Feb 2019 17:13:52 +0000
>"Bean Huo (beanhuo)" <[email protected]> wrote:
>
>> Hi, Tutor
>> Thanks. unfortunately, it doesn't work on my side. Problem is on our email
>server side, not my local setting.
>> I followed your configuration, then git-email failed.
>
>Can you paste the output of git send-email and the [sendemail] section of
>your .gitconfig so we can check.
>It shouldn't fail, really, because the server shouldn't check the body section of
>your email, and this is where the extra
>
> From: First Last <[email protected]>
>
>line is placed.
>
>> Please just change my S-o-b to 'Bean Huo (beanhuo) <[email protected]>'
>in my patch to please checkpacth.pl. It is not huge change.
>
>It's not a problem when an drive-by contributor posts a patch, but if you don't
>patch it that means we'll have to do it manually every time we apply one of your
>patch, so please find a solution.
>
>Thanks,
>
>Boris
On 2/8/19 7:43 PM, Bean Huo (beanhuo) wrote:
> Hi,Boris
> I sent three times, seems last time is successful. would you check that is correct?
>
> git send-email 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
> 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
git send-email --annotate --to=... --cc=... --cc=... 000*patch
This will likely make your life easier, rather than having to paste
various email addresses to git send-email queries.
[...]
--
Best regards,
Marek Vasut
On Fri, 8 Feb 2019 18:43:26 +0000
"Bean Huo (beanhuo)" <[email protected]> wrote:
> Hi,Boris
> I sent three times, seems last time is successful. would you check that is correct?
That's much better now, thanks!
>> git send-email 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>> 0001-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
>
>git send-email --annotate --to=... --cc=... --cc=... 000*patch
>
>This will likely make your life easier, rather than having to paste various email
>addresses to git send-email queries.
>
Yes, thanks.
>[...]
>
>--
>Best regards,
>Marek Vasut
>
>______________________________________________________
>Linux MTD discussion mailing list
>http://lists.infradead.org/mailman/listinfo/linux-mtd/