2023-12-04 13:10:05

by Siddh Raman Pant

Subject: [PATCH net-next v3 2/2] nfc: Do not send datagram if socket state isn't LLCP_BOUND

As we know we cannot send the datagram (state can be set to LLCP_CLOSED
by nfc_llcp_socket_release()), there is no need to proceed further.

Thus, bail out early from llcp_sock_sendmsg().

Signed-off-by: Siddh Raman Pant <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
net/nfc/llcp_sock.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c
index 645677f84dba..819157bbb5a2 100644
--- a/net/nfc/llcp_sock.c
+++ b/net/nfc/llcp_sock.c
@@ -796,6 +796,11 @@ static int llcp_sock_sendmsg(struct socket *sock, struct msghdr *msg,
}

if (sk->sk_type == SOCK_DGRAM) {
+ if (sk->sk_state != LLCP_BOUND) {
+ release_sock(sk);
+ return -ENOTCONN;
+ }
+
DECLARE_SOCKADDR(struct sockaddr_nfc_llcp *, addr,
msg->msg_name);

--
2.42.0

2023-12-05 11:05:26

by Suman Ghosh

Subject: RE: [EXT] [PATCH net-next v3 2/2] nfc: Do not send datagram if socket state isn't LLCP_BOUND

>As we know we cannot send the datagram (state can be set to LLCP_CLOSED
>by nfc_llcp_socket_release()), there is no need to proceed further.
>
>Thus, bail out early from llcp_sock_sendmsg().
>
>Signed-off-by: Siddh Raman Pant <[email protected]>
>Reviewed-by: Krzysztof Kozlowski <[email protected]>
>---
Reviewed-by: Suman Ghosh <[email protected]>
> net/nfc/llcp_sock.c | 5 +++++