Deferred probe is an expected return value for tegra_fuse_readl().
Given that the driver deals with it properly, there's no need to
output a warning that may potentially confuse users.
Signed-off-by: Jon Hunter <[email protected]>
---
drivers/phy/tegra/xusb-tegra186.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
index 84c27394c181..12d0f3e30dbc 100644
--- a/drivers/phy/tegra/xusb-tegra186.c
+++ b/drivers/phy/tegra/xusb-tegra186.c
@@ -802,7 +802,9 @@ tegra186_xusb_read_fuse_calibration(struct tegra186_xusb_padctl *padctl)
err = tegra_fuse_readl(TEGRA_FUSE_SKU_CALIB_0, &value);
if (err) {
- dev_err(dev, "failed to read calibration fuse: %d\n", err);
+ if (err != -EPROBE_DEFER)
+ dev_err(dev, "failed to read calibration fuse: %d\n",
+ err);
return err;
}
--
2.17.1
On Mon, Feb 24, 2020 at 02:36:41PM +0000, Jon Hunter wrote:
> Deferred probe is an expected return value for tegra_fuse_readl().
> Given that the driver deals with it properly, there's no need to
> output a warning that may potentially confuse users.
>
> Signed-off-by: Jon Hunter <[email protected]>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Kishon,
I already have a couple of PHY subsystem patches from JC and Nagarjuna
in a branch in the Tegra tree that I need to resolve a dependency. Do
you mind if I pick this up into that branch as well and send it to you
as a pull request later on? Say around v5.6-rc6?
Alternatively you could provide an Acked-by and then I can take them all
through ARM SoC.
Thierry
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index 84c27394c181..12d0f3e30dbc 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -802,7 +802,9 @@ tegra186_xusb_read_fuse_calibration(struct tegra186_xusb_padctl *padctl)
>
> err = tegra_fuse_readl(TEGRA_FUSE_SKU_CALIB_0, &value);
> if (err) {
> - dev_err(dev, "failed to read calibration fuse: %d\n", err);
> + if (err != -EPROBE_DEFER)
> + dev_err(dev, "failed to read calibration fuse: %d\n",
> + err);
> return err;
> }
>
> --
> 2.17.1
>
Hi Thierry,
On 24/02/20 8:42 pm, Thierry Reding wrote:
> On Mon, Feb 24, 2020 at 02:36:41PM +0000, Jon Hunter wrote:
>> Deferred probe is an expected return value for tegra_fuse_readl().
>> Given that the driver deals with it properly, there's no need to
>> output a warning that may potentially confuse users.
>>
>> Signed-off-by: Jon Hunter <[email protected]>
>> ---
>> drivers/phy/tegra/xusb-tegra186.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Kishon,
>
> I already have a couple of PHY subsystem patches from JC and Nagarjuna
> in a branch in the Tegra tree that I need to resolve a dependency. Do
> you mind if I pick this up into that branch as well and send it to you
> as a pull request later on? Say around v5.6-rc6?
You can take this via Tegra tree itself.
Acked-by: Kishon Vijay Abraham I <[email protected]>
-Kishon
>
> Alternatively you could provide an Acked-by and then I can take them all
> through ARM SoC.
>
> Thierry
>
>> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
>> index 84c27394c181..12d0f3e30dbc 100644
>> --- a/drivers/phy/tegra/xusb-tegra186.c
>> +++ b/drivers/phy/tegra/xusb-tegra186.c
>> @@ -802,7 +802,9 @@ tegra186_xusb_read_fuse_calibration(struct tegra186_xusb_padctl *padctl)
>>
>> err = tegra_fuse_readl(TEGRA_FUSE_SKU_CALIB_0, &value);
>> if (err) {
>> - dev_err(dev, "failed to read calibration fuse: %d\n", err);
>> + if (err != -EPROBE_DEFER)
>> + dev_err(dev, "failed to read calibration fuse: %d\n",
>> + err);
>> return err;
>> }
>>
>> --
>> 2.17.1
>>