2020-07-30 23:03:08

by Jonathan Bakker

Subject: [PATCH v2 11/11] dt-bindings: media: Correct samsung-fimc parallel port numbering

The parallel port nodes should be numbered 1 and 2, not 0 and 1
for A and B respectively. The driver has always implemented 1
and 2 and the in-tree Goni DTS uses 1 as port A as well. Update
the documentation to match this behaviour.

Signed-off-by: Jonathan Bakker <[email protected]>
---
Changes from v1:
- New patch replacing patch modifying driver to match documentation
---
Documentation/devicetree/bindings/media/samsung-fimc.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt
index f91b9dc80eb3..20447529c985 100644
--- a/Documentation/devicetree/bindings/media/samsung-fimc.txt
+++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt
@@ -95,7 +95,7 @@ Optional properties:

This node should contain child 'port' nodes specifying active parallel video
input ports. It includes camera A and camera B inputs. 'reg' property in the
-port nodes specifies data input - 0, 1 indicates input A, B respectively.
+port nodes specifies data input - 1, 2 indicates input A, B respectively.

Optional properties

@@ -172,8 +172,8 @@ Example:
/* parallel camera ports */
parallel-ports {
/* camera A input */
- port@0 {
- reg = <0>;
+ port@1 {
+ reg = <1>;
fimc0_ep: endpoint {
remote-endpoint = <&s5k6aa_ep>;
bus-width = <8>;
--
2.20.1

2020-07-31 10:00:43

by Sylwester Nawrocki

Subject: Re: [PATCH v2 11/11] dt-bindings: media: Correct samsung-fimc parallel port numbering

On 31.07.2020 01:01, Jonathan Bakker wrote:
> The parallel port nodes should be numbered 1 and 2, not 0 and 1
> for A and B respectively. The driver has always implemented 1
> and 2 and the in-tree Goni DTS uses 1 as port A as well. Update
> the documentation to match this behaviour.
>
> Signed-off-by: Jonathan Bakker <[email protected]>

Reviewed-by: Sylwester Nawrocki <[email protected]>

Thanks for all those improvements, whole series looks good to me.

--
Regards,
Sylwester

2020-07-31 22:43:51

by Rob Herring

Subject: Re: [PATCH v2 11/11] dt-bindings: media: Correct samsung-fimc parallel port numbering

On Thu, 30 Jul 2020 16:01:14 -0700, Jonathan Bakker wrote:
> The parallel port nodes should be numbered 1 and 2, not 0 and 1
> for A and B respectively. The driver has always implemented 1
> and 2 and the in-tree Goni DTS uses 1 as port A as well. Update
> the documentation to match this behaviour.
>
> Signed-off-by: Jonathan Bakker <[email protected]>
> ---
> Changes from v1:
> - New patch replacing patch modifying driver to match documentation
> ---
> Documentation/devicetree/bindings/media/samsung-fimc.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>