2023-06-07 17:25:05

by Robin Murphy

Subject: [PATCH RESEND] PCI: Add function 1 DMA alias quirk for Marvell 88SE9235

Marvell's own product brief implies the 92xx series are a closely
related family, and sure enough it turns out that 9235 seems to need the
same quirk as the other three, although possibly only when certain ports
are used.

CC: [email protected]
Reported-by: Jason Adriaanse <[email protected]>
Link: https://lore.kernel.org/linux-iommu/[email protected]/
Signed-off-by: Robin Murphy <[email protected]>
---

Note that the actual regression which started the thread is a different
matter, wherein a particular combination of parameters which used to put
intel-iommu into passthrough mode now enables full translation instead.

Take #2, hopefully not royally screwing up my email alises this time.
Sorry about that...

drivers/pci/quirks.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index f4e2a88729fd..3186f2c84eab 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -4174,6 +4174,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9220,
/* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c49 */
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9230,
quirk_dma_func1_alias);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9235,
+ quirk_dma_func1_alias);
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
quirk_dma_func1_alias);
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0645,
--
2.39.2.101.g768bb238c484.dirty

2023-06-08 05:19:12

by Christoph Hellwig

Subject: Re: [PATCH RESEND] PCI: Add function 1 DMA alias quirk for Marvell 88SE9235

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2023-06-08 17:27:29

by Bjorn Helgaas

Subject: Re: [PATCH RESEND] PCI: Add function 1 DMA alias quirk for Marvell 88SE9235

On Wed, Jun 07, 2023 at 06:18:47PM +0100, Robin Murphy wrote:
> Marvell's own product brief implies the 92xx series are a closely
> related family, and sure enough it turns out that 9235 seems to need the
> same quirk as the other three, although possibly only when certain ports
> are used.
>
> CC: [email protected]
> Reported-by: Jason Adriaanse <[email protected]>
> Link: https://lore.kernel.org/linux-iommu/[email protected]/
> Signed-off-by: Robin Murphy <[email protected]>

Applied with Christoph's reviewed-by to pci/virtualization for v6.5,
thanks!

> ---
>
> Note that the actual regression which started the thread is a different
> matter, wherein a particular combination of parameters which used to put
> intel-iommu into passthrough mode now enables full translation instead.
>
> Take #2, hopefully not royally screwing up my email alises this time.
> Sorry about that...
>
> drivers/pci/quirks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index f4e2a88729fd..3186f2c84eab 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4174,6 +4174,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9220,
> /* https://bugzilla.kernel.org/show_bug.cgi?id=42679#c49 */
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9230,
> quirk_dma_func1_alias);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MARVELL_EXT, 0x9235,
> + quirk_dma_func1_alias);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0642,
> quirk_dma_func1_alias);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TTI, 0x0645,
> --
> 2.39.2.101.g768bb238c484.dirty
>