2017-12-04 22:58:04

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: [PATCH] rtlwifi: rtl818x: remove redundant check for cck_power > 15


--------------------------------------------
On Tue, 14/11/17, Colin King <[email protected]> wrote:


> From: Colin Ian King <[email protected]>

> cck_poweri cannot be greated than 15 as
> is derived from the bottom 4 bits
> from riv->channels[channel -
> 1].hw_value & 0xf.  Hence the check for it
> being greater than 15 is redundant and
> can be removed.

> Detected by CoverityScan, CID#744303
> ("Logically dead code")

> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Hin-Tak Leung <[email protected]>