Document nvmem-cells compatible used to treat mtd partitions as a
nvmem provider.
Signed-off-by: Ansuel Smith <[email protected]>
---
.../bindings/mtd/partitions/nvmem-cells.yaml | 99 +++++++++++++++++++
1 file changed, 99 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
new file mode 100644
index 000000000000..b53faf87d4e4
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nvmem cells
+
+description: |
+ Any partition containing the compatible "nvmem-cells" will register as a
+ nvmem provider.
+ Each direct subnodes represents a nvmem cell following the nvmem binding.
+ Nvmem binding to declare nvmem-cells can be found in:
+ Documentation/devicetree/bindings/nvmem/nvmem.yaml
+
+maintainers:
+ - Ansuel Smith <[email protected]>
+
+allOf:
+ - $ref: "../../nvmem/nvmem.yaml#"
+
+properties:
+ compatible:
+ const: nvmem-cells
+
+required:
+ - compatible
+
+additionalProperties: true
+
+examples:
+ - |
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ /* ... */
+
+ };
+ art: art@1200000 {
+ compatible = "nvmem-cells";
+ reg = <0x1200000 0x0140000>;
+ label = "art";
+ read-only;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ macaddr_gmac1: macaddr_gmac1@0 {
+ reg = <0x0 0x6>;
+ };
+
+ macaddr_gmac2: macaddr_gmac2@6 {
+ reg = <0x6 0x6>;
+ };
+
+ pre_cal_24g: pre_cal_24g@1000 {
+ reg = <0x1000 0x2f20>;
+ };
+
+ pre_cal_5g: pre_cal_5g@5000{
+ reg = <0x5000 0x2f20>;
+ };
+ };
+ - |
+ partitions {
+ compatible = "fixed-partitions";
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ partition@0 {
+ label = "bootloader";
+ reg = <0x000000 0x100000>;
+ read-only;
+ };
+
+ firmware@100000 {
+ compatible = "brcm,trx";
+ label = "firmware";
+ reg = <0x100000 0xe00000>;
+ };
+
+ calibration@f00000 {
+ compatible = "nvmem-cells";
+ label = "calibration";
+ reg = <0xf00000 0x100000>;
+ ranges = <0 0xf00000 0x100000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ wifi0@0 {
+ reg = <0x000000 0x080000>;
+ };
+
+ wifi1@80000 {
+ reg = <0x080000 0x080000>;
+ };
+ };
+ };
--
2.30.0
On Thu, 11 Mar 2021 06:12:48 +0100, Ansuel Smith wrote:
> Document nvmem-cells compatible used to treat mtd partitions as a
> nvmem provider.
>
> Signed-off-by: Ansuel Smith <[email protected]>
> ---
> .../bindings/mtd/partitions/nvmem-cells.yaml | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.example.dt.yaml: art@1200000: $nodename:0: 'art@1200000' does not match '^(eeprom|efuse|nvram)(@.*|-[0-9a-f])*$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.example.dt.yaml: calibration@f00000: $nodename:0: 'calibration@f00000' does not match '^(eeprom|efuse|nvram)(@.*|-[0-9a-f])*$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
See https://patchwork.ozlabs.org/patch/1451109
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
On Thu, Mar 11, 2021 at 09:41:02AM -0700, Rob Herring wrote:
> On Thu, 11 Mar 2021 06:12:48 +0100, Ansuel Smith wrote:
> > Document nvmem-cells compatible used to treat mtd partitions as a
> > nvmem provider.
> >
> > Signed-off-by: Ansuel Smith <[email protected]>
> > ---
> > .../bindings/mtd/partitions/nvmem-cells.yaml | 99 +++++++++++++++++++
> > 1 file changed, 99 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.example.dt.yaml: art@1200000: $nodename:0: 'art@1200000' does not match '^(eeprom|efuse|nvram)(@.*|-[0-9a-f])*$'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.example.dt.yaml: calibration@f00000: $nodename:0: 'calibration@f00000' does not match '^(eeprom|efuse|nvram)(@.*|-[0-9a-f])*$'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
Looks like you need to reorder patches.
>
> See https://patchwork.ozlabs.org/patch/1451109
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
On Thu, Mar 11, 2021 at 06:12:48AM +0100, Ansuel Smith wrote:
> Document nvmem-cells compatible used to treat mtd partitions as a
> nvmem provider.
>
> Signed-off-by: Ansuel Smith <[email protected]>
> ---
> .../bindings/mtd/partitions/nvmem-cells.yaml | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> new file mode 100644
> index 000000000000..b53faf87d4e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nvmem cells
> +
> +description: |
> + Any partition containing the compatible "nvmem-cells" will register as a
> + nvmem provider.
> + Each direct subnodes represents a nvmem cell following the nvmem binding.
> + Nvmem binding to declare nvmem-cells can be found in:
> + Documentation/devicetree/bindings/nvmem/nvmem.yaml
> +
> +maintainers:
> + - Ansuel Smith <[email protected]>
> +
> +allOf:
> + - $ref: "../../nvmem/nvmem.yaml#"
I'd rather have the 'absolute' path:
/schemas/nvmem/nvmem.yaml
Otherwise,
Reviewed-by: Rob Herring <[email protected]>
> +
> +properties:
> + compatible:
> + const: nvmem-cells
> +
> +required:
> + - compatible
> +
> +additionalProperties: true
> +
> +examples:
> + - |
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + /* ... */
> +
> + };
> + art: art@1200000 {
> + compatible = "nvmem-cells";
> + reg = <0x1200000 0x0140000>;
> + label = "art";
> + read-only;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + macaddr_gmac1: macaddr_gmac1@0 {
> + reg = <0x0 0x6>;
> + };
> +
> + macaddr_gmac2: macaddr_gmac2@6 {
> + reg = <0x6 0x6>;
> + };
> +
> + pre_cal_24g: pre_cal_24g@1000 {
> + reg = <0x1000 0x2f20>;
> + };
> +
> + pre_cal_5g: pre_cal_5g@5000{
> + reg = <0x5000 0x2f20>;
> + };
> + };
> + - |
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + partition@0 {
> + label = "bootloader";
> + reg = <0x000000 0x100000>;
> + read-only;
> + };
> +
> + firmware@100000 {
> + compatible = "brcm,trx";
> + label = "firmware";
> + reg = <0x100000 0xe00000>;
> + };
> +
> + calibration@f00000 {
> + compatible = "nvmem-cells";
> + label = "calibration";
> + reg = <0xf00000 0x100000>;
> + ranges = <0 0xf00000 0x100000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + wifi0@0 {
> + reg = <0x000000 0x080000>;
> + };
> +
> + wifi1@80000 {
> + reg = <0x080000 0x080000>;
> + };
> + };
> + };
> --
> 2.30.0
>
On Thu, Mar 11, 2021 at 10:32:21AM -0700, Rob Herring wrote:
> On Thu, Mar 11, 2021 at 06:12:48AM +0100, Ansuel Smith wrote:
> > Document nvmem-cells compatible used to treat mtd partitions as a
> > nvmem provider.
> >
> > Signed-off-by: Ansuel Smith <[email protected]>
> > ---
> > .../bindings/mtd/partitions/nvmem-cells.yaml | 99 +++++++++++++++++++
> > 1 file changed, 99 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> > new file mode 100644
> > index 000000000000..b53faf87d4e4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> > @@ -0,0 +1,99 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nvmem cells
> > +
> > +description: |
> > + Any partition containing the compatible "nvmem-cells" will register as a
> > + nvmem provider.
> > + Each direct subnodes represents a nvmem cell following the nvmem binding.
> > + Nvmem binding to declare nvmem-cells can be found in:
> > + Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > +
> > +maintainers:
> > + - Ansuel Smith <[email protected]>
> > +
> > +allOf:
> > + - $ref: "../../nvmem/nvmem.yaml#"
>
> I'd rather have the 'absolute' path:
>
> /schemas/nvmem/nvmem.yaml
>
> Otherwise,
>
> Reviewed-by: Rob Herring <[email protected]>
>
Should I send a v7?
> > +
> > +properties:
> > + compatible:
> > + const: nvmem-cells
> > +
> > +required:
> > + - compatible
> > +
> > +additionalProperties: true
> > +
> > +examples:
> > + - |
> > + partitions {
> > + compatible = "fixed-partitions";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + /* ... */
> > +
> > + };
> > + art: art@1200000 {
> > + compatible = "nvmem-cells";
> > + reg = <0x1200000 0x0140000>;
> > + label = "art";
> > + read-only;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + macaddr_gmac1: macaddr_gmac1@0 {
> > + reg = <0x0 0x6>;
> > + };
> > +
> > + macaddr_gmac2: macaddr_gmac2@6 {
> > + reg = <0x6 0x6>;
> > + };
> > +
> > + pre_cal_24g: pre_cal_24g@1000 {
> > + reg = <0x1000 0x2f20>;
> > + };
> > +
> > + pre_cal_5g: pre_cal_5g@5000{
> > + reg = <0x5000 0x2f20>;
> > + };
> > + };
> > + - |
> > + partitions {
> > + compatible = "fixed-partitions";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + partition@0 {
> > + label = "bootloader";
> > + reg = <0x000000 0x100000>;
> > + read-only;
> > + };
> > +
> > + firmware@100000 {
> > + compatible = "brcm,trx";
> > + label = "firmware";
> > + reg = <0x100000 0xe00000>;
> > + };
> > +
> > + calibration@f00000 {
> > + compatible = "nvmem-cells";
> > + label = "calibration";
> > + reg = <0xf00000 0x100000>;
> > + ranges = <0 0xf00000 0x100000>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + wifi0@0 {
> > + reg = <0x000000 0x080000>;
> > + };
> > +
> > + wifi1@80000 {
> > + reg = <0x080000 0x080000>;
> > + };
> > + };
> > + };
> > --
> > 2.30.0
> >
On 11.03.2021 11:50, Ansuel Smith wrote:
> On Thu, Mar 11, 2021 at 10:32:21AM -0700, Rob Herring wrote:
>> On Thu, Mar 11, 2021 at 06:12:48AM +0100, Ansuel Smith wrote:
>>> Document nvmem-cells compatible used to treat mtd partitions as a
>>> nvmem provider.
>>>
>>> Signed-off-by: Ansuel Smith <[email protected]>
>>> ---
>>> .../bindings/mtd/partitions/nvmem-cells.yaml | 99 +++++++++++++++++++
>>> 1 file changed, 99 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>> new file mode 100644
>>> index 000000000000..b53faf87d4e4
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>> @@ -0,0 +1,99 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Nvmem cells
>>> +
>>> +description: |
>>> + Any partition containing the compatible "nvmem-cells" will register as a
>>> + nvmem provider.
>>> + Each direct subnodes represents a nvmem cell following the nvmem binding.
>>> + Nvmem binding to declare nvmem-cells can be found in:
>>> + Documentation/devicetree/bindings/nvmem/nvmem.yaml
>>> +
>>> +maintainers:
>>> + - Ansuel Smith <[email protected]>
>>> +
>>> +allOf:
>>> + - $ref: "../../nvmem/nvmem.yaml#"
>>
>> I'd rather have the 'absolute' path:
>>
>> /schemas/nvmem/nvmem.yaml
>>
>> Otherwise,
>>
>> Reviewed-by: Rob Herring <[email protected]>
>>
>
> Should I send a v7?
Yes, please, let's make it the right way :)
When sending V7 please:
1. Include above "Reviewed-by" in the "dt-bindings: mtd: Document use of nvmem-cells compatible"
2. Include my "Tested-by" in the "mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells"
Reference:
[PATCH v2 2/3] mtd: core: add nvmem-partitions compatible to parse mtd as nvmem cells
https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/