2022-09-14 07:36:21

by Jinjie Ruan

[permalink] [raw]
Subject: [PATCH -next] xen-netfront: make bounce_skb static

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

./drivers/net/xen-netfront.c:676:16: warning: symbol 'bounce_skb' was not declared. Should it be static?

Signed-off-by: ruanjinjie <[email protected]>
---
drivers/net/xen-netfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 27a11cc08c61..2cb7e741e1a2 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -673,7 +673,7 @@ static int xennet_xdp_xmit(struct net_device *dev, int n,
return nxmit;
}

-struct sk_buff *bounce_skb(const struct sk_buff *skb)
+static struct sk_buff *bounce_skb(const struct sk_buff *skb)
{
unsigned int headerlen = skb_headroom(skb);
/* Align size to allocate full pages and avoid contiguous data leaks */
--
2.25.1


2022-09-14 09:45:41

by Jürgen Groß

[permalink] [raw]
Subject: Re: [PATCH -next] xen-netfront: make bounce_skb static

On 14.09.22 08:43, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> ./drivers/net/xen-netfront.c:676:16: warning: symbol 'bounce_skb' was not declared. Should it be static?
>
> Signed-off-by: ruanjinjie <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Juergen


Attachments:
OpenPGP_0xB0DE9DD628BF132F.asc (3.08 kB)
OpenPGP public key
OpenPGP_signature (505.00 B)
OpenPGP digital signature
Download all attachments

2022-09-20 15:50:44

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH -next] xen-netfront: make bounce_skb static

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 14 Sep 2022 14:43:39 +0800 you wrote:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> ./drivers/net/xen-netfront.c:676:16: warning: symbol 'bounce_skb' was not declared. Should it be static?
>
> Signed-off-by: ruanjinjie <[email protected]>
>
> [...]

Here is the summary with links:
- [-next] xen-netfront: make bounce_skb static
https://git.kernel.org/netdev/net-next/c/53ff25170980

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html