2021-07-20 03:45:11

by Xianting Tian

Subject: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()

From: Xianting Tian <[email protected]>

Add the missed virtio_device_ready() to set vsock frontend ready.

Signed-off-by: Xianting Tian <[email protected]>
---
net/vmw_vsock/virtio_transport.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index e0c2c992a..eb4c607c4 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
vdev->priv = vsock;
rcu_assign_pointer(the_virtio_vsock, vsock);

+ virtio_device_ready(vdev);
+
mutex_unlock(&the_virtio_vsock_mutex);

return 0;
--
2.17.1

2021-07-20 03:46:25

by Xianting Tian

Subject: Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()

Please help review this one, thanks

ignore the one https://lkml.org/lkml/2021/7/19/3279
<https://lkml.org/lkml/2021/7/19/3279>, which contains wrong mail address.

?? 2021/7/20 ????11:42, Xianting Tian д??:
> From: Xianting Tian <[email protected]>
>
> Add the missed virtio_device_ready() to set vsock frontend ready.
>
> Signed-off-by: Xianting Tian <[email protected]>
> ---
> net/vmw_vsock/virtio_transport.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index e0c2c992a..eb4c607c4 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
> vdev->priv = vsock;
> rcu_assign_pointer(the_virtio_vsock, vsock);
>
> + virtio_device_ready(vdev);
> +
> mutex_unlock(&the_virtio_vsock_mutex);
>
> return 0;

2021-07-20 06:30:28

by Jason Wang

Subject: Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()

?? 2021/7/20 ????11:42, Xianting Tian д??:
> From: Xianting Tian <[email protected]>
>
> Add the missed virtio_device_ready() to set vsock frontend ready.
>
> Signed-off-by: Xianting Tian <[email protected]>
> ---
> net/vmw_vsock/virtio_transport.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index e0c2c992a..eb4c607c4 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
> vdev->priv = vsock;
> rcu_assign_pointer(the_virtio_vsock, vsock);
>
> + virtio_device_ready(vdev);
> +
> mutex_unlock(&the_virtio_vsock_mutex);


It's better to do this after the mutex_lock().

Thanks


>
> return 0;

2021-07-20 07:08:13

by Xianting Tian

Subject: Re: [PATCH] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()

thanks ,

I will sent V2 patch.

在 2021/7/20 下午2:28, Jason Wang 写道:
>
> 在 2021/7/20 上午11:42, Xianting Tian 写道:
>> From: Xianting Tian <[email protected]>
>>
>> Add the missed virtio_device_ready() to set vsock frontend ready.
>>
>> Signed-off-by: Xianting Tian <[email protected]>
>> ---
>>   net/vmw_vsock/virtio_transport.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/net/vmw_vsock/virtio_transport.c
>> b/net/vmw_vsock/virtio_transport.c
>> index e0c2c992a..eb4c607c4 100644
>> --- a/net/vmw_vsock/virtio_transport.c
>> +++ b/net/vmw_vsock/virtio_transport.c
>> @@ -637,6 +637,8 @@ static int virtio_vsock_probe(struct
>> virtio_device *vdev)
>>       vdev->priv = vsock;
>>       rcu_assign_pointer(the_virtio_vsock, vsock);
>>   +    virtio_device_ready(vdev);
>> +
>>       mutex_unlock(&the_virtio_vsock_mutex);
>
>
> It's better to do this after the mutex_lock().
>
> Thanks
>
>
>>         return 0;