2018-01-04 10:50:54

by SF Markus Elfring

Subject: [PATCH 0/2] mtd/maps/sun_uflash: Adjustments for uflash_devinit()

From: Markus Elfring <[email protected]>
Date: Thu, 4 Jan 2018 11:45:54 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/mtd/maps/sun_uflash.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.15.1

2018-01-04 10:51:46

by SF Markus Elfring

Subject: [PATCH 1/2] mtd/maps/sun_uflash: Delete an error message for a failed memory allocation in uflash_devinit()

From: Markus Elfring <[email protected]>
Date: Thu, 4 Jan 2018 10:20:14 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mtd/maps/sun_uflash.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c
index 1e73bba6e286..80a253cc72e2 100644
--- a/drivers/mtd/maps/sun_uflash.c
+++ b/drivers/mtd/maps/sun_uflash.c
@@ -62,10 +62,8 @@ int uflash_devinit(struct platform_device *op, struct device_node *dp)
}

up = kzalloc(sizeof(struct uflash_dev), GFP_KERNEL);
- if (!up) {
- printk(KERN_ERR PFX "Cannot allocate struct uflash_dev\n");
+ if (!up)
return -ENOMEM;
- }

/* copy defaults and tweak parameters */
memcpy(&up->map, &uflash_map_templ, sizeof(uflash_map_templ));
--
2.15.1

2018-01-04 10:53:09

by SF Markus Elfring

Subject: [PATCH 2/2] mtd/maps/sun_uflash: Improve a size determination in uflash_devinit()

From: Markus Elfring <[email protected]>
Date: Thu, 4 Jan 2018 11:38:28 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mtd/maps/sun_uflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c
index 80a253cc72e2..16a4f16a2680 100644
--- a/drivers/mtd/maps/sun_uflash.c
+++ b/drivers/mtd/maps/sun_uflash.c
@@ -61,7 +61,7 @@ int uflash_devinit(struct platform_device *op, struct device_node *dp)
return -ENODEV;
}

- up = kzalloc(sizeof(struct uflash_dev), GFP_KERNEL);
+ up = kzalloc(sizeof(*up), GFP_KERNEL);
if (!up)
return -ENOMEM;

--
2.15.1