Hi,
out of boredom I grepped 2.6.12-rc1-mm4 for swapped memset arguments.
I found one:
# grep -nr "memset.*\,\(\ \|\)0\(\ \|\));" *
net/ieee80211/ieee80211_tx.c:226: memset(txb, sizeof(struct ieee80211_txb), 0);
I found none in Linus' bk.
Regards,
Maciej
On Sat, 2 Apr 2005, Maciej Soltysiak wrote:
> Hi,
>
> out of boredom I grepped 2.6.12-rc1-mm4 for swapped memset arguments.
> I found one:
>
> # grep -nr "memset.*\,\(\ \|\)0\(\ \|\));" *
> net/ieee80211/ieee80211_tx.c:226: memset(txb, sizeof(struct ieee80211_txb), 0);
>
And here's a patch :
Fix swapped memset() arguments in net/ieee80211/ieee80211_tx.c
found by Maciej Soltysiak.
Signed-off-by: Jesper Juhl <[email protected]>
--- linux-2.6.12-rc1-mm4-orig/net/ieee80211/ieee80211_tx.c 2005-03-31 21:20:08.000000000 +0200
+++ linux-2.6.12-rc1-mm4/net/ieee80211/ieee80211_tx.c 2005-04-03 00:34:22.000000000 +0200
@@ -223,7 +223,7 @@ struct ieee80211_txb *ieee80211_alloc_tx
if (!txb)
return NULL;
- memset(txb, sizeof(struct ieee80211_txb), 0);
+ memset(txb, 0, sizeof(struct ieee80211_txb));
txb->nr_frags = nr_frags;
txb->frag_size = txb_size;
On Sunday 03 April 2005 01:38, Jesper Juhl wrote:
> On Sat, 2 Apr 2005, Maciej Soltysiak wrote:
>
> > Hi,
> >
> > out of boredom I grepped 2.6.12-rc1-mm4 for swapped memset arguments.
> > I found one:
> >
> > # grep -nr "memset.*\,\(\ \|\)0\(\ \|\));" *
> > net/ieee80211/ieee80211_tx.c:226: memset(txb, sizeof(struct ieee80211_txb), 0);
> >
> And here's a patch :
>
>
> Fix swapped memset() arguments in net/ieee80211/ieee80211_tx.c
> found by Maciej Soltysiak.
This one will stop these from happening again.
(Well, at least on i386)...
--
vda