2022-01-21 19:13:45

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH v3 9/9] brcmfmac: pcie: Read the console on init and shutdown

On 1/17/2022 3:29 PM, Hector Martin wrote:
> This allows us to get console messages if the firmware crashed during
> early init, or if an operation failed and we're about to shut down.

We do have a module parameter that forces probing to succeed regardless
any failure so we can create memory dump of the wifi device, read the
console, etc. Still it can be useful to add these console read calls.
Thanks.

Reviewed-by: Arend van Spriel <[email protected]>
> Reviewed-by: Linus Walleij <[email protected]>
> Signed-off-by: Hector Martin <[email protected]>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 4 ++++
> 1 file changed, 4 insertions(+)


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature