2021-06-21 12:25:30

by Matthew Wilcox

[permalink] [raw]
Subject: [PATCH] block: Include mm_types.h instead of mm.h

There's no need to include all of mm.h in bvec.h. It only needs a few
things like the definition of struct page, PAGE_SIZE, PAGE_MASK and so
on, all of which are provided by mm_types.h.

Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
---
include/linux/bvec.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index ff832e698efb..a0f3ccc09aba 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -11,7 +11,7 @@
#include <linux/errno.h>
#include <linux/limits.h>
#include <linux/minmax.h>
-#include <linux/mm.h>
+#include <linux/mm_types.h>
#include <linux/types.h>

struct page;
--
2.30.2


2021-06-21 15:53:09

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH] block: Include mm_types.h instead of mm.h

On 6/21/21 5:24 AM, Matthew Wilcox (Oracle) wrote:
> There's no need to include all of mm.h in bvec.h. It only needs a few
> things like the definition of struct page, PAGE_SIZE, PAGE_MASK and so
> on, all of which are provided by mm_types.h.

Reviewed-by: Bart Van Assche <[email protected]>

2021-06-21 15:56:37

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] block: Include mm_types.h instead of mm.h

On 6/21/21 6:24 AM, Matthew Wilcox (Oracle) wrote:
> There's no need to include all of mm.h in bvec.h. It only needs a few
> things like the definition of struct page, PAGE_SIZE, PAGE_MASK and so
> on, all of which are provided by mm_types.h.

Applied, thanks.

--
Jens Axboe