2012-02-02 18:04:27

by Stephen Warren

[permalink] [raw]
Subject: RE: [PATCH v2 8/8] ARM: tegra: support for secondary cores on Tegra30

Peter De Schrijver wrote at Tuesday, January 31, 2012 9:41 AM:
> Add support for bringing up secondary cores on Tegra30. On Tegra30 secondary
> CPU cores are powergated, so we need to turn on the domains before we can bring
> the CPU cores online. Bringing secondary cores online happens early during the
> sytem boot, so we call powergating initialization from platform early_init
> function.
>
> Based on work by:
>
> Scott Williams <[email protected]>
> Colin Cross <[email protected]>
> Alex Frid <[email protected]>
>
> Signed-off-by: Peter De Schrijver <[email protected]>

The series,

Tested-by: Stephen Warren <[email protected]>

This time, since I now have the SD card working, I managed to test real
user-space processes running on all 4 cores.

Note, patch 3 shouldn't compile due to a typo in a .size directive. It
does for me, so I could test this! But, it didn't for Olof. Aside from
that (which perhaps Olof would fixup during patch application?),

Acked-by: Stephen Warren <[email protected]>

I also have a query on patch 3 about enabling coresight, but that's more
for my education than something that'd block patch application.

--
nvpublic


2012-02-06 23:23:39

by Peter De Schrijver

[permalink] [raw]
Subject: Re: [PATCH v2 8/8] ARM: tegra: support for secondary cores on Tegra30

On Thu, Feb 02, 2012 at 07:04:12PM +0100, Stephen Warren wrote:
> Peter De Schrijver wrote at Tuesday, January 31, 2012 9:41 AM:
> > Add support for bringing up secondary cores on Tegra30. On Tegra30 secondary
> > CPU cores are powergated, so we need to turn on the domains before we can bring
> > the CPU cores online. Bringing secondary cores online happens early during the
> > sytem boot, so we call powergating initialization from platform early_init
> > function.
> >
> > Based on work by:
> >
> > Scott Williams <[email protected]>
> > Colin Cross <[email protected]>
> > Alex Frid <[email protected]>
> >
> > Signed-off-by: Peter De Schrijver <[email protected]>
>
> The series,
>
> Tested-by: Stephen Warren <[email protected]>
>
> This time, since I now have the SD card working, I managed to test real
> user-space processes running on all 4 cores.
>
> Note, patch 3 shouldn't compile due to a typo in a .size directive. It
> does for me, so I could test this! But, it didn't for Olof. Aside from
> that (which perhaps Olof would fixup during patch application?),

Indeed. The .size symbol is never used though, which might explain why it
compiled for you and me. I will leave it out in th enext version.

Cheers,

Peter.