On 11/3/2023 11:55 PM, Zhengqiao Xia wrote:
> Hi Jessica ,
>
>> Fixes: 6069b66cd962 ("drm/panel: support for STARRY 2081101QFH032011-53G
> MIPI-DSI panel")
>
> I'm not very familiar with this upstream process, Where should I add these?
You can add the Fixes tag before the signed-off-by. For example [1]:
Fixes: 01d6c3578379 ("drm/syncobj: add support for timeline point wait v8")
Signed-off-by: Erik Kurzinger <[email protected]>
<...>
Thanks,
Jessica Zhang
[1]
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=101c9f637efa1655f55876644d4439e552267527
>
> Thanks
>
>
> On Sat, Nov 4, 2023 at 2:40 AM Jessica Zhang <[email protected]>
>> wrote:
>>
>>
>> On 11/2/2023 6:08 AM, xiazhengqiao wrote:
>>> For "starry, 2081101qfh032011-53g" this panel, it is stipulated in the
>> Hi Zhengqiao,
>> Nit: Can you reword this to "For the "starry, 2081101qfh032011-53g"
>> panel..."?
>>> panel spec that MIPI needs to keep the LP11 state before the
>>> lcm_reset pin is pulled high.
>> Was this fixing some panel issue? If so, maybe we can add
>> Fixes: 6069b66cd962 ("drm/panel: support for STARRY 2081101QFH032011-53G
>> MIPI-DSI panel")
>> Otherwise, with the commit msg fix, this looks good to me:
>> Reviewed-by: Jessica Zhang <[email protected]>
>> Thanks,
>> Jessica Zhang
>>
>>
>>>
>>> Signed-off-by: xiazhengqiao <[email protected]
>>>
>>
>> ---
>>> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
>> b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
>>> index 4f370bc6dca8..4ed8c2e28d37 100644
>>> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
>>> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
>>> @@ -1765,6 +1765,7 @@ static const struct panel_desc
>> starry_qfh032011_53g_desc = {
>>> .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE
>> |
>>> MIPI_DSI_MODE_LPM,
>>> .init_cmds = starry_qfh032011_53g_init_cmd,
>>> + .lp11_before_reset = true,
>>> };
>>>
>>> static const struct drm_display_mode
>> starry_himax83102_j02_default_mode = {
>>> --
>>> 2.17.1
>>>
>>
>