2023-09-26 19:00:25

by Nipun Gupta

[permalink] [raw]
Subject: Re: [PATCH v4] cdx: add MSI support for CDX bus

Hi Thomas/Marc,

On 9/11/2023 7:22 PM, Nipun Gupta wrote:
> Add CDX-MSI domain per CDX controller with gic-its domain as
> a parent, to support MSI for CDX devices. CDX devices allocate
> MSIs from the CDX domain. Also, introduce APIs to alloc and free
> IRQs for CDX domain.
>
> In CDX subsystem firmware is a controller for all devices and
> their configuration. CDX bus controller sends all the write_msi_msg
> commands to firmware running on RPU and the firmware interfaces with
> actual devices to pass this information to devices
>
> Since, CDX controller is the only way to communicate with the Firmware
> for MSI write info, CDX domain per controller required in contrast to
> having a CDX domain per device.
>
> Co-developed-by: Nikhil Agarwal <[email protected]>
> Signed-off-by: Nikhil Agarwal <[email protected]>
> Co-developed-by: Abhijit Gangurde <[email protected]>
> Signed-off-by: Abhijit Gangurde <[email protected]>
> Signed-off-by: Nipun Gupta <[email protected]>
> Reviewed-by: Pieter Jansen van Vuuren <[email protected]>
> Tested-by: Nikhil Agarwal <[email protected]>
> ---
>
> Changes v3->v4:
> - Rebased on Linux 6.6-rc1

Can you please help in reviewing and making progress on this patch?

Thanks,
Nipun