2022-11-12 15:43:01

by Aidan MacDonald

Subject: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base

Remove use of the deprecated mask_invert flag. Inverted mask
registers (where a '1' bit enables an IRQ) can be described more
directly as an unmask register.

Signed-off-by: Aidan MacDonald <[email protected]>
---
drivers/gpio/gpio-sl28cpld.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c
index 52404736ac86..2195f88c2048 100644
--- a/drivers/gpio/gpio-sl28cpld.c
+++ b/drivers/gpio/gpio-sl28cpld.c
@@ -70,8 +70,7 @@ static int sl28cpld_gpio_irq_init(struct platform_device *pdev,
irq_chip->num_irqs = ARRAY_SIZE(sl28cpld_gpio_irqs);
irq_chip->num_regs = 1;
irq_chip->status_base = base + GPIO_REG_IP;
- irq_chip->mask_base = base + GPIO_REG_IE;
- irq_chip->mask_invert = true;
+ irq_chip->unmask_base = base + GPIO_REG_IE;
irq_chip->ack_base = base + GPIO_REG_IP;

ret = devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev),
--
2.38.1

2022-11-14 10:33:07

by Linus Walleij

Subject: Re: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base

On Sat, Nov 12, 2022 at 4:29 PM Aidan MacDonald
<[email protected]> wrote:

> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <[email protected]>

Makes sense
Acked-by: Linus Walleij <[email protected]>

I expected to see Maz on CC for this kind of patches so added him.

Yours,
Linus Walleij

2022-11-15 15:18:09

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base

On Sat, Nov 12, 2022 at 4:29 PM Aidan MacDonald
<[email protected]> wrote:
>
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <[email protected]>
> ---
> drivers/gpio/gpio-sl28cpld.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c
> index 52404736ac86..2195f88c2048 100644
> --- a/drivers/gpio/gpio-sl28cpld.c
> +++ b/drivers/gpio/gpio-sl28cpld.c
> @@ -70,8 +70,7 @@ static int sl28cpld_gpio_irq_init(struct platform_device *pdev,
> irq_chip->num_irqs = ARRAY_SIZE(sl28cpld_gpio_irqs);
> irq_chip->num_regs = 1;
> irq_chip->status_base = base + GPIO_REG_IP;
> - irq_chip->mask_base = base + GPIO_REG_IE;
> - irq_chip->mask_invert = true;
> + irq_chip->unmask_base = base + GPIO_REG_IE;
> irq_chip->ack_base = base + GPIO_REG_IP;
>
> ret = devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev),
> --
> 2.38.1
>

Applied, thanks!

Bartosz

2022-11-16 07:15:04

by Michael Walle

Subject: Re: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base

Am 2022-11-12 16:29, schrieb Aidan MacDonald:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <[email protected]>

Sorry for the late response, I was on vacation.

I see that it was already applied, so just for the record:
Acked-by: Michael Walle <[email protected]>

Thanks for taking care,
-michael