2022-10-18 18:28:59

by Bart Van Assche

Subject: Re: [PATCH v3 1/3] scsi: ufs: core: Remove unnecessary if statement

On 10/18/22 11:16, Bean Huo wrote:
> From: Bean Huo <[email protected]>
>
> LUs with WB potential support are properly checked in ufshcd_wb_probe()
> before calling ufshcd_read_unit_desc_param(), so remove this unnecessary
> if-checkup in ufs_is_valid_unit_desc_lun() to match its function definition.

Hi Bean,

Does this patch differ from a revert of Jaegeuk's patch? If not, please
change the patch title into "Revert scsi: ufs: WB is only available on
LUN #0 to #7" and add "Cc: Jaegeuk Kim <[email protected]>" just above
the Signed-off-by line.

Thanks,

Bart.

2022-10-18 18:49:47

by Bean Huo

Subject: Re: [PATCH v3 1/3] scsi: ufs: core: Remove unnecessary if statement

On Tue, 2022-10-18 at 11:20 -0700, Bart Van Assche wrote:
> On 10/18/22 11:16, Bean Huo wrote:
> > From: Bean Huo <[email protected]>
> >
> > LUs with WB potential support are properly checked in
> > ufshcd_wb_probe()
> > before calling ufshcd_read_unit_desc_param(), so remove this
> > unnecessary
> > if-checkup in ufs_is_valid_unit_desc_lun() to match its function
> > definition.
>
> Hi Bean,
>
> Does this patch differ from a revert of Jaegeuk's patch? If not,
> please
> change the patch title into "Revert scsi: ufs: WB is only available
> on
> LUN #0 to #7" and add "Cc: Jaegeuk Kim <[email protected]>" just
> above
> the Signed-off-by line.
>
> Thanks,
>
> Bart.

Bart,

no difference, I will change its title and CC Jaegeuk.

thanks,
Bean