2020-06-02 06:19:09

by Yue Haibing

Subject: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free()

dummy_netdev shold be freed by free_netdev() instead of
kfree(). Also remove unneeded variable 'priv'

Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
index 58af6a454761..63688e85e8da 100644
--- a/drivers/infiniband/hw/hfi1/netdev_rx.c
+++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
@@ -371,12 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd)

void hfi1_netdev_free(struct hfi1_devdata *dd)
{
- struct hfi1_netdev_priv *priv;
-
if (dd->dummy_netdev) {
- priv = hfi1_netdev_priv(dd->dummy_netdev);
dd_dev_info(dd, "hfi1 netdev freed\n");
- kfree(dd->dummy_netdev);
+ free_netdev(dd->dummy_netdev);
dd->dummy_netdev = NULL;
}
}
--
2.17.1

2020-06-02 15:33:02

by Dennis Dalessandro

Subject: Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free()

On 6/2/2020 2:16 AM, YueHaibing wrote:
> dummy_netdev shold be freed by free_netdev() instead of
> kfree(). Also remove unneeded variable 'priv'
>
> Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
> index 58af6a454761..63688e85e8da 100644
> --- a/drivers/infiniband/hw/hfi1/netdev_rx.c
> +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
> @@ -371,12 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd)
>
> void hfi1_netdev_free(struct hfi1_devdata *dd)
> {
> - struct hfi1_netdev_priv *priv;
> -
> if (dd->dummy_netdev) {
> - priv = hfi1_netdev_priv(dd->dummy_netdev);
> dd_dev_info(dd, "hfi1 netdev freed\n");
> - kfree(dd->dummy_netdev);
> + free_netdev(dd->dummy_netdev);
> dd->dummy_netdev = NULL;
> }
> }
>

For the kfree->free_netdev, you probably want to add:
Reported-by: kbuild test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

Also can add:
Reviewed-by: Dennis Dalessandro <[email protected]>

Thanks

2020-06-02 18:43:51

by Dan Carpenter

Subject: Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free()

On Tue, Jun 02, 2020 at 11:30:13AM -0400, Dennis Dalessandro wrote:
> On 6/2/2020 2:16 AM, YueHaibing wrote:
> > dummy_netdev shold be freed by free_netdev() instead of
> > kfree(). Also remove unneeded variable 'priv'
> >
> > Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev")
> > Signed-off-by: YueHaibing <[email protected]>
> > ---
> > drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c
> > index 58af6a454761..63688e85e8da 100644
> > --- a/drivers/infiniband/hw/hfi1/netdev_rx.c
> > +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c
> > @@ -371,12 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd)
> > void hfi1_netdev_free(struct hfi1_devdata *dd)
> > {
> > - struct hfi1_netdev_priv *priv;
> > -
> > if (dd->dummy_netdev) {
> > - priv = hfi1_netdev_priv(dd->dummy_netdev);
> > dd_dev_info(dd, "hfi1 netdev freed\n");
> > - kfree(dd->dummy_netdev);
> > + free_netdev(dd->dummy_netdev);
> > dd->dummy_netdev = NULL;
> > }
> > }
> >
>
> For the kfree->free_netdev, you probably want to add:
> Reported-by: kbuild test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>

YueHaibing wasn't on the CC list when I sent forwarded that kbuild bot
email. Forget about it. Let's just apply this.

regards,
dan carpenter

2020-06-03 00:38:16

by Jason Gunthorpe

Subject: Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free()

On Tue, Jun 02, 2020 at 02:16:35PM +0800, YueHaibing wrote:
> dummy_netdev shold be freed by free_netdev() instead of
> kfree(). Also remove unneeded variable 'priv'
>
> Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev")
> Signed-off-by: YueHaibing <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Reviewed-by: Dennis Dalessandro <[email protected]>
> ---
> drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)

Applied to for-next, thanks

Jason