2023-03-23 06:02:11

by Mingxuan Xiang

Subject: [PATCH] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

platform_get_irq() no longer returns 0, so there is no
need to check whether the return value is 0.

Signed-off-by: Mingxuan Xiang <[email protected]>
---
drivers/usb/dwc3/host.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f6f13e7f1ba1..aa19c27344e6 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -57,9 +57,6 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
goto out;
}

- if (!irq)
- irq = -EINVAL;
-
out:
return irq;
}
--
2.39.2

2023-03-23 09:08:25

by Sergei Shtylyov

Subject: Re: [PATCH] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

On 3/23/23 8:42 AM, Mingxuan Xiang wrote:

> platform_get_irq() no longer returns 0, so there is no
> need to check whether the return value is 0.
>
> Signed-off-by: Mingxuan Xiang <[email protected]>
> ---
> drivers/usb/dwc3/host.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index f6f13e7f1ba1..aa19c27344e6 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -57,9 +57,6 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
> goto out;

Shouldn't *goto* be dropped now?

> }
>
> - if (!irq)
> - irq = -EINVAL;
> -
> out:
> return irq;
> }

MBR, Sergey