2017-11-28 13:42:26

by Bob Peterson

[permalink] [raw]
Subject: Re: [PATCH] gfs2: Fix wrong error handling in init_gfs2_fs()

----- Original Message -----
| init_gfs2_fs() is calling e.g. calling unregister_shrinker() without
| register_shrinker() when an error occurred during initialization.
| Rename goto labels and call appropriate undo function.
|
| Signed-off-by: Tetsuo Handa <[email protected]>
| ---
| fs/gfs2/main.c | 90
| ++++++++++++++++++++++++++++------------------------------
| 1 file changed, 44 insertions(+), 46 deletions(-)
Hi,

ACK.

Thanks; this is a nice cleanup.

This is now pushed to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=8b0d7f56b97b95a442b6785027a0f80ad1ea54af

Regards,

Bob Peterson
Red Hat File Systems

From 1584835310117096454@xxx Thu Nov 23 05:58:50 +0000 2017
X-GM-THRID: 1584835310117096454
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread