2019-08-22 04:24:27

by Ben Wei

Subject: [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands

Update response packet length for the following commands per NC-SI spec
- Get Controller Packet Statistics
- Get NC-SI Statistics
- Get NC-SI Pass-through Statistics command

Signed-off-by: Ben Wei <[email protected]>
---
net/ncsi/ncsi-rsp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 7581bf919885..5254004f2b42 100644
--- a/net/ncsi/ncsi-rsp.c
+++ b/net/ncsi/ncsi-rsp.c
@@ -1083,9 +1083,9 @@ static struct ncsi_rsp_handler {
{ NCSI_PKT_RSP_GVI, 40, ncsi_rsp_handler_gvi },
{ NCSI_PKT_RSP_GC, 32, ncsi_rsp_handler_gc },
{ NCSI_PKT_RSP_GP, -1, ncsi_rsp_handler_gp },
- { NCSI_PKT_RSP_GCPS, 172, ncsi_rsp_handler_gcps },
- { NCSI_PKT_RSP_GNS, 172, ncsi_rsp_handler_gns },
- { NCSI_PKT_RSP_GNPTS, 172, ncsi_rsp_handler_gnpts },
+ { NCSI_PKT_RSP_GCPS, 204, ncsi_rsp_handler_gcps },
+ { NCSI_PKT_RSP_GNS, 32, ncsi_rsp_handler_gns },
+ { NCSI_PKT_RSP_GNPTS, 48, ncsi_rsp_handler_gnpts },
{ NCSI_PKT_RSP_GPS, 8, ncsi_rsp_handler_gps },
{ NCSI_PKT_RSP_OEM, -1, ncsi_rsp_handler_oem },
{ NCSI_PKT_RSP_PLDM, 0, NULL },
--
2.17.1

2019-08-22 04:47:28

by Justin.Lee1

Subject: RE: [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands

Hi Ben,

Those are correct adjustment and I had tested previously.

Thanks,
Justin


Reviewed-by: Justin Lee <[email protected]>


> Update response packet length for the following commands per NC-SI spec
> - Get Controller Packet Statistics
> - Get NC-SI Statistics
> - Get NC-SI Pass-through Statistics command
>
> Signed-off-by: Ben Wei <[email protected]>
> ---
> net/ncsi/ncsi-rsp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c index 7581bf919885..5254004f2b42 100644
> --- a/net/ncsi/ncsi-rsp.c
> +++ b/net/ncsi/ncsi-rsp.c
> @@ -1083,9 +1083,9 @@ static struct ncsi_rsp_handler {
> { NCSI_PKT_RSP_GVI, 40, ncsi_rsp_handler_gvi },
> { NCSI_PKT_RSP_GC, 32, ncsi_rsp_handler_gc },
> { NCSI_PKT_RSP_GP, -1, ncsi_rsp_handler_gp },
> - { NCSI_PKT_RSP_GCPS, 172, ncsi_rsp_handler_gcps },
> - { NCSI_PKT_RSP_GNS, 172, ncsi_rsp_handler_gns },
> - { NCSI_PKT_RSP_GNPTS, 172, ncsi_rsp_handler_gnpts },
> + { NCSI_PKT_RSP_GCPS, 204, ncsi_rsp_handler_gcps },
> + { NCSI_PKT_RSP_GNS, 32, ncsi_rsp_handler_gns },
> + { NCSI_PKT_RSP_GNPTS, 48, ncsi_rsp_handler_gnpts },
> { NCSI_PKT_RSP_GPS, 8, ncsi_rsp_handler_gps },
> { NCSI_PKT_RSP_OEM, -1, ncsi_rsp_handler_oem },
> { NCSI_PKT_RSP_PLDM, 0, NULL },
> --
> 2.17.1

2019-08-23 09:50:11

by David Miller

Subject: Re: [PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands

From: Ben Wei <[email protected]>
Date: Wed, 21 Aug 2019 22:08:49 +0000

> Update response packet length for the following commands per NC-SI spec
> - Get Controller Packet Statistics
> - Get NC-SI Statistics
> - Get NC-SI Pass-through Statistics command
>
> Signed-off-by: Ben Wei <[email protected]>

Applied, thanks Ben.