Use the kernel wide ARRAY_SIZE when determining the array size of a struct.
Signed-off-by: Jerry Stralko <[email protected]>
---
diff --git a/arch/arm/kernel/dma-isa.c b/arch/arm/kernel/dma-isa.c
index 0a3e9ad..c94ad71 100644
--- a/arch/arm/kernel/dma-isa.c
+++ b/arch/arm/kernel/dma-isa.c
@@ -19,6 +19,7 @@
#include <linux/ioport.h>
#include <linux/init.h>
#include <linux/dma-mapping.h>
+#include <linux/kernel.h>
#include <asm/dma.h>
#include <asm/io.h>
@@ -216,7 +217,7 @@ void __init isa_init_dma(dma_t *dma)
request_dma(DMA_ISA_CASCADE, "cascade");
- for (i = 0; i < sizeof(dma_resources) /
sizeof(dma_resources[0]); i++)
+ for (i = 0; i < ARRAY_SIZE(dma_resources); i++)
request_resource(&ioport_resource, dma_resources + i);
}
}
On Wed, May 23, 2007 at 01:27:11PM -0400, Gerb Stralko wrote:
> Use the kernel wide ARRAY_SIZE when determining the array size of a struct.
>
> Signed-off-by: Jerry Stralko <[email protected]>
Whitespace damanged patch, probably due to using format=flowed in your
mailer. Please get a proper mail client. 8)
Also, please note that ARM and ARM26 are two separate architectures
maintained by two separate people. Please don't confuse them and
merge patches - it's about the same level of evilness as labelling
PPC and i386 as one architecture and expecting PPC folk to take the
lot.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
On 5/23/07, Russell King <[email protected]> wrote:
> On Wed, May 23, 2007 at 01:27:11PM -0400, Gerb Stralko wrote:
> > Use the kernel wide ARRAY_SIZE when determining the array size of a struct.
> >
> > Signed-off-by: Jerry Stralko <[email protected]>
>
> Whitespace damanged patch, probably due to using format=flowed in your
> mailer. Please get a proper mail client. 8)
Sorry about that one. I didn't realize my mailer was being stupid.
I'll see if I can fix _or_ get a new mailer, and maybe send out a
better patch :)
> Also, please note that ARM and ARM26 are two separate architectures
> maintained by two separate people. Please don't confuse them and
> merge patches - it's about the same level of evilness as labelling
> PPC and i386 as one architecture and expecting PPC folk to take the
> lot.
Ok, sorry about that, I don't want to cause you any more confusion or
frustration. I'm a newbie in this area and just wanted to help out
and learn. Thanks for being polite about it...instead of chewing my
head off - your a good man.
> --
> Russell King
> Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
> maintainer of:
>