2023-05-09 12:02:09

by Varadarajan Narayanan

Subject: [PATCH v11 2/9] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY

* Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574

* Making power-domains as optional since IPQ9574 doesn't have GDSCs

Signed-off-by: Varadarajan Narayanan <[email protected]>
---
Changes in v11:
- Have power-domains as required for non ipq9574 SoCs

Changes in v10:
- Remove maxItems for clocks as it is present in top level

Changes in v9:
- Move 'allOf' to the correct position

Changes in v8:
- Update clock names for ipq9574

Changes in v6:
- Made power-domains optional

Note: In the earlier patch sets, had used the (legacy)
specification available in qcom,msm8996-qmp-usb3-phy.yaml. Moved
to newer specification in qcom,sc8280xp-qmp-usb3-uni-phy.yaml
---
.../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 44 +++++++++++++++++++---
1 file changed, 38 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
index c61cea4..a272c40 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
@@ -16,6 +16,7 @@ description:
properties:
compatible:
enum:
+ - qcom,ipq9574-qmp-usb3-phy
- qcom,sa8775p-qmp-usb3-uni-phy
- qcom,sc8280xp-qmp-usb3-uni-phy

@@ -26,11 +27,7 @@ properties:
maxItems: 4

clock-names:
- items:
- - const: aux
- - const: ref
- - const: com_aux
- - const: pipe
+ maxItems: 4

power-domains:
maxItems: 1
@@ -61,7 +58,6 @@ required:
- reg
- clocks
- clock-names
- - power-domains
- resets
- reset-names
- vdda-phy-supply
@@ -70,6 +66,42 @@ required:
- clock-output-names
- "#phy-cells"

+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,ipq9574-qmp-usb3-phy
+ then:
+ properties:
+ clock-names:
+ items:
+ - const: aux
+ - const: ref
+ - const: cfg_ahb
+ - const: pipe
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sa8775p-qmp-usb3-uni-phy
+ - qcom,sc8280xp-qmp-usb3-uni-phy
+ then:
+ properties:
+ clocks:
+ maxItems: 4
+ clock-names:
+ items:
+ - const: aux
+ - const: ref
+ - const: com_aux
+ - const: pipe
+ required:
+ - power-domains
+
additionalProperties: false

examples:
--
2.7.4

2023-05-09 17:50:37

by Krzysztof Kozlowski

Subject: Re: [PATCH v11 2/9] dt-bindings: phy: qcom,qmp-usb: Add IPQ9574 USB3 PHY

On 09/05/2023 13:54, Varadarajan Narayanan wrote:
> * Add dt-bindings for USB3 PHY found on Qualcomm IPQ9574
>
> * Making power-domains as optional since IPQ9574 doesn't have GDSCs
>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---
> Changes in v11:
> - Have power-domains as required for non ipq9574 SoCs

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof