From: Conor Dooley <[email protected]>
Commit 5621d3977e29 ("dt-bindings: mfd: Add missing (unevaluated|
additional)Properties on child nodes") exposed a flaw in the original
binding, where "merged" versions of some regulators were missing,
leading to warnings on the HiFive Unmatched Devicetree.
Add the missing patterns (and merge some of the trivial ones).
Signed-off-by: Conor Dooley <[email protected]>
---
I opted not to include a fixes tag for the conversion since it just
converted what was already there. I figured the original text binding
is just incomplete rather than "broken", but if you don't agree the
fixes tag would be:
Fixes: c7f15d43a5c5 ("mfd: devicetree: Add bindings for DA9063")
Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
index 54b47bd4c6aa..e8e74e91070c 100644
--- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
+++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
@@ -73,7 +73,7 @@ properties:
type: object
additionalProperties: false
patternProperties:
- "^(ldo([1-9]|1[01])|bcore[1-2]|bpro|bmem|bio|bperi)$":
+ "^(ldo([1-9]|1[01])|bcore([1-2]|s-merged)|b(pro|mem|io|peri)|bmem-bio-merged)$":
$ref: /schemas/regulator/regulator.yaml
unevaluatedProperties: false
--
2.37.3
On 16/09/2022 20:00, Conor Dooley wrote:
> From: Conor Dooley <[email protected]>
>
> Commit 5621d3977e29 ("dt-bindings: mfd: Add missing (unevaluated|
> additional)Properties on child nodes") exposed a flaw in the original
> binding, where "merged" versions of some regulators were missing,
> leading to warnings on the HiFive Unmatched Devicetree.
>
> Add the missing patterns (and merge some of the trivial ones).
>
> Signed-off-by: Conor Dooley <[email protected]>
> ---
> I opted not to include a fixes tag for the conversion since it just
> converted what was already there. I figured the original text binding
> is just incomplete rather than "broken", but if you don't agree the
> fixes tag would be:
> Fixes: c7f15d43a5c5 ("mfd: devicetree: Add bindings for DA9063")
>
> Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 2 +-
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 17 September 2022 17:44:06 IST, Krzysztof Kozlowski <[email protected]> wrote:
>On 16/09/2022 20:00, Conor Dooley wrote:
>> From: Conor Dooley <[email protected]>
>>
>> Commit 5621d3977e29 ("dt-bindings: mfd: Add missing (unevaluated|
>> additional)Properties on child nodes") exposed a flaw in the original
>> binding, where "merged" versions of some regulators were missing,
>> leading to warnings on the HiFive Unmatched Devicetree.
>>
>> Add the missing patterns (and merge some of the trivial ones).
>>
>> Signed-off-by: Conor Dooley <[email protected]>
>> ---
>> I opted not to include a fixes tag for the conversion since it just
>> converted what was already there. I figured the original text binding
>> is just incomplete rather than "broken", but if you don't agree the
>> fixes tag would be:
>> Fixes: c7f15d43a5c5 ("mfd: devicetree: Add bindings for DA9063")
>>
>> Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 2 +-
>
>
>Acked-by: Krzysztof Kozlowski <[email protected]>
>
Hey Lee,
Is it too late to pick this up for 6.1?
It's the last remaining dt warning in for riscv.
Thanks,
Conor
On Fri, 16 Sep 2022, Conor Dooley wrote:
> From: Conor Dooley <[email protected]>
>
> Commit 5621d3977e29 ("dt-bindings: mfd: Add missing (unevaluated|
> additional)Properties on child nodes") exposed a flaw in the original
> binding, where "merged" versions of some regulators were missing,
> leading to warnings on the HiFive Unmatched Devicetree.
>
> Add the missing patterns (and merge some of the trivial ones).
>
> Signed-off-by: Conor Dooley <[email protected]>
> ---
> I opted not to include a fixes tag for the conversion since it just
> converted what was already there. I figured the original text binding
> is just incomplete rather than "broken", but if you don't agree the
> fixes tag would be:
> Fixes: c7f15d43a5c5 ("mfd: devicetree: Add bindings for DA9063")
>
> Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]