2023-11-22 00:49:45

by Yang Li

Subject: [PATCH -next] drm/nouveau/fifo: Remove duplicated include in chan.c

./drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c: chid.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7603
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
index 87a62d4ff4bd..7d4716dcd512 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
@@ -24,7 +24,6 @@
#include "chan.h"
#include "chid.h"
#include "cgrp.h"
-#include "chid.h"
#include "runl.h"
#include "priv.h"

--
2.20.1.7.g153144c

2023-11-22 20:22:11

by Lyude Paul

Subject: Re: [PATCH -next] drm/nouveau/fifo: Remove duplicated include in chan.c

Reviewed-by: Lyude Paul <[email protected]>

Will push upstream in a moment

On Wed, 2023-11-22 at 08:49 +0800, Yang Li wrote:
> ./drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c: chid.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7603
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
> index 87a62d4ff4bd..7d4716dcd512 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
> @@ -24,7 +24,6 @@
> #include "chan.h"
> #include "chid.h"
> #include "cgrp.h"
> -#include "chid.h"
> #include "runl.h"
> #include "priv.h"
>

--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat