2022-05-21 03:05:13

by Pavel Skripkin

[permalink] [raw]
Subject: [PATCH v2 4/4] MAINTAINERS: add myself as r8188eu reviewer

I was reviewing r8188eu patches for a while, but I am missing some of
them, since I am not in CC list. I want to be CC'ed to help reviewing
and testing more patches.

Acked-by: Dan Carpenter <[email protected]>
Signed-off-by: Pavel Skripkin <[email protected]>
---

Changes since v1:
- Added Dan's Ack. Thanks to Dan! :)

---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0a635f2ae5b9..bd38a2e465cc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18716,6 +18716,7 @@ F: drivers/staging/olpc_dcon/
STAGING - REALTEK RTL8188EU DRIVERS
M: Larry Finger <[email protected]>
M: Phillip Potter <[email protected]>
+R: Pavel Skripkin <[email protected]>
S: Supported
F: drivers/staging/r8188eu/

--
2.36.1



2022-06-06 06:37:32

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH v2 4/4] MAINTAINERS: add myself as r8188eu reviewer

On Fri, May 20, 2022 at 12:10:08AM +0300, Pavel Skripkin wrote:
> I was reviewing r8188eu patches for a while, but I am missing some of
> them, since I am not in CC list. I want to be CC'ed to help reviewing
> and testing more patches.
>
> Acked-by: Dan Carpenter <[email protected]>
> Signed-off-by: Pavel Skripkin <[email protected]>
> ---
>
> Changes since v1:
> - Added Dan's Ack. Thanks to Dan! :)
>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0a635f2ae5b9..bd38a2e465cc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18716,6 +18716,7 @@ F: drivers/staging/olpc_dcon/
> STAGING - REALTEK RTL8188EU DRIVERS
> M: Larry Finger <[email protected]>
> M: Phillip Potter <[email protected]>
> +R: Pavel Skripkin <[email protected]>

For obvious reasons, I can't take changes like this unless the
maintainers agree with it.

thanks,

greg k-h

2022-06-06 08:09:16

by Phillip Potter

[permalink] [raw]
Subject: Re: [PATCH v2 4/4] MAINTAINERS: add myself as r8188eu reviewer

On Mon, Jun 06, 2022 at 07:49:26AM +0200, Greg KH wrote:
> On Fri, May 20, 2022 at 12:10:08AM +0300, Pavel Skripkin wrote:
> > I was reviewing r8188eu patches for a while, but I am missing some of
> > them, since I am not in CC list. I want to be CC'ed to help reviewing
> > and testing more patches.
> >
> > Acked-by: Dan Carpenter <[email protected]>
> > Signed-off-by: Pavel Skripkin <[email protected]>
> > ---
> >
> > Changes since v1:
> > - Added Dan's Ack. Thanks to Dan! :)
> >
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 0a635f2ae5b9..bd38a2e465cc 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18716,6 +18716,7 @@ F: drivers/staging/olpc_dcon/
> > STAGING - REALTEK RTL8188EU DRIVERS
> > M: Larry Finger <[email protected]>
> > M: Phillip Potter <[email protected]>
> > +R: Pavel Skripkin <[email protected]>
>
> For obvious reasons, I can't take changes like this unless the
> maintainers agree with it.
>
> thanks,
>
> greg k-h

Hi Greg,

Speaking only for myself of course, I would be happy for Pavel to be
added as a reviewer in MAINTAINERS.

He is helpful and skilful at what he does, and certainly makes up for the
small amount of time I get to spend looking at r8188eu :-)

Acked-by: Phillip Potter <[email protected]>

Many thanks,
Phil