2022-11-15 11:18:26

by Srinivasa Rao Mandadapu

Subject: [PATCH] arm64: dts: SC7280: Remove unused sleep pin control nodes

Remove Unused and redundant sleep pin control entries
in herobrine device tree variants.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
---
.../qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi | 8 -----
.../dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi | 20 -----------
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 20 -----------
arch/arm64/boot/dts/qcom/sc7280.dtsi | 40 ----------------------
4 files changed, 88 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi
index cf34334..1ca11a1 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682-3mic.dtsi
@@ -148,10 +148,6 @@ hp_i2c: &i2c2 {
bias-disable;
};

-&lpass_dmic01_clk_sleep {
- drive-strength = <2>;
-};
-
&lpass_dmic01_data {
bias-pull-down;
};
@@ -161,10 +157,6 @@ hp_i2c: &i2c2 {
bias-disable;
};

-&lpass_dmic23_clk_sleep {
- drive-strength = <2>;
-};
-
&lpass_dmic23_data {
bias-pull-down;
};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
index c72e53a..ae25520 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
@@ -167,10 +167,6 @@
bias-disable;
};

-&lpass_dmic01_clk_sleep {
- drive-strength = <2>;
-};
-
&lpass_dmic01_data {
bias-pull-down;
};
@@ -180,10 +176,6 @@
bias-disable;
};

-&lpass_dmic23_clk_sleep {
- drive-strength = <2>;
-};
-
&lpass_dmic23_data {
bias-pull-down;
};
@@ -194,30 +186,18 @@
bias-disable;
};

-&lpass_rx_swr_clk_sleep {
- bias-pull-down;
-};
-
&lpass_rx_swr_data {
drive-strength = <2>;
slew-rate = <1>;
bias-bus-hold;
};

-&lpass_rx_swr_data_sleep {
- bias-pull-down;
-};
-
&lpass_tx_swr_clk {
drive-strength = <2>;
slew-rate = <1>;
bias-disable;
};

-&lpass_tx_swr_clk_sleep {
- bias-pull-down;
-};
-
&lpass_tx_swr_data {
drive-strength = <2>;
slew-rate = <1>;
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 8ca2281..f7efb99 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -576,10 +576,6 @@
bias-disable;
};

-&lpass_dmic01_clk_sleep {
- drive-strength = <2>;
-};
-
&lpass_dmic01_data {
bias-pull-down;
};
@@ -589,10 +585,6 @@
bias-disable;
};

-&lpass_dmic23_clk_sleep {
- drive-strength = <2>;
-};
-
&lpass_dmic23_data {
bias-pull-down;
};
@@ -603,30 +595,18 @@
bias-disable;
};

-&lpass_rx_swr_clk_sleep {
- bias-pull-down;
-};
-
&lpass_rx_swr_data {
drive-strength = <2>;
slew-rate = <1>;
bias-bus-hold;
};

-&lpass_rx_swr_data_sleep {
- bias-pull-down;
-};
-
&lpass_tx_swr_clk {
drive-strength = <2>;
slew-rate = <1>;
bias-disable;
};

-&lpass_tx_swr_clk_sleep {
- bias-pull-down;
-};
-
&lpass_tx_swr_data {
drive-strength = <2>;
slew-rate = <1>;
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 448879d..4970864 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2483,80 +2483,40 @@
function = "dmic1_clk";
};

- lpass_dmic01_clk_sleep: dmic01-clk-sleep-state {
- pins = "gpio6";
- function = "dmic1_clk";
- };
-
lpass_dmic01_data: dmic01-data-state {
pins = "gpio7";
function = "dmic1_data";
};

- lpass_dmic01_data_sleep: dmic01-data-sleep-state {
- pins = "gpio7";
- function = "dmic1_data";
- };
-
lpass_dmic23_clk: dmic23-clk-state {
pins = "gpio8";
function = "dmic2_clk";
};

- lpass_dmic23_clk_sleep: dmic23-clk-sleep-state {
- pins = "gpio8";
- function = "dmic2_clk";
- };
-
lpass_dmic23_data: dmic23-data-state {
pins = "gpio9";
function = "dmic2_data";
};

- lpass_dmic23_data_sleep: dmic23-data-sleep-state {
- pins = "gpio9";
- function = "dmic2_data";
- };
-
lpass_rx_swr_clk: rx-swr-clk-state {
pins = "gpio3";
function = "swr_rx_clk";
};

- lpass_rx_swr_clk_sleep: rx-swr-clk-sleep-state {
- pins = "gpio3";
- function = "swr_rx_clk";
- };
-
lpass_rx_swr_data: rx-swr-data-state {
pins = "gpio4", "gpio5";
function = "swr_rx_data";
};

- lpass_rx_swr_data_sleep: rx-swr-data-sleep-state {
- pins = "gpio4", "gpio5";
- function = "swr_rx_data";
- };
-
lpass_tx_swr_clk: tx-swr-clk-state {
pins = "gpio0";
function = "swr_tx_clk";
};

- lpass_tx_swr_clk_sleep: tx-swr-clk-sleep-state {
- pins = "gpio0";
- function = "swr_tx_clk";
- };
-
lpass_tx_swr_data: tx-swr-data-state {
pins = "gpio1", "gpio2", "gpio14";
function = "swr_tx_data";
};
-
- lpass_tx_swr_data_sleep: tx-swr-data-sleep-state {
- pins = "gpio1", "gpio2", "gpio14";
- function = "swr_tx_data";
- };
};

gpu: gpu@3d00000 {
--
2.7.4

2022-11-15 14:00:21

by Krzysztof Kozlowski

Subject: Re: [PATCH] arm64: dts: SC7280: Remove unused sleep pin control nodes

On 15/11/2022 12:09, Srinivasa Rao Mandadapu wrote:
> Remove Unused and redundant sleep pin control entries
> in herobrine device tree variants.
>

And these are redundant because... ? E.g. not referenced anywhere thus
not used?

Use subject prefixes matching the subsystem (git log --oneline -- ...).

Best regards,
Krzysztof