2022-11-19 00:37:46

by Uwe Kleine-König

Subject: [PATCH 496/606] mtd: maps: pismo: Convert to i2c's .probe_new()

From: Uwe Kleine-König <[email protected]>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/mtd/maps/pismo.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/maps/pismo.c b/drivers/mtd/maps/pismo.c
index 5fcefcd0baca..3e0fff3f129e 100644
--- a/drivers/mtd/maps/pismo.c
+++ b/drivers/mtd/maps/pismo.c
@@ -206,8 +206,7 @@ static void pismo_remove(struct i2c_client *client)
kfree(pismo);
}

-static int pismo_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int pismo_probe(struct i2c_client *client)
{
struct pismo_pdata *pdata = client->dev.platform_data;
struct pismo_eeprom eeprom;
@@ -260,7 +259,7 @@ static struct i2c_driver pismo_driver = {
.driver = {
.name = "pismo",
},
- .probe = pismo_probe,
+ .probe_new = pismo_probe,
.remove = pismo_remove,
.id_table = pismo_id,
};
--
2.38.1

2023-02-01 12:13:53

by Richard Weinberger

Subject: Re: [PATCH 496/606] mtd: maps: pismo: Convert to i2c's .probe_new()

----- Ursprüngliche Mail -----
> Von: "Uwe Kleine-König" <[email protected]>
> An: "Angel Iglesias" <[email protected]>, "Lee Jones" <[email protected]>, "Grant Likely"
> <[email protected]>, "Wolfram Sang" <[email protected]>, "Miquel Raynal" <[email protected]>, "richard"
> <[email protected]>, "Vignesh Raghavendra" <[email protected]>, "Sebastian Reichel" <[email protected]>,
> "Maximilian Luz" <[email protected]>, "Peter Rosin" <[email protected]>, "Benjamin Mugnier"
> <[email protected]>
> CC: [email protected], "kernel" <[email protected]>, "Uwe Kleine-König" <[email protected]>,
> "linux-mtd" <[email protected]>, "linux-kernel" <[email protected]>
> Gesendet: Freitag, 18. November 2022 23:43:50
> Betreff: [PATCH 496/606] mtd: maps: pismo: Convert to i2c's .probe_new()

> From: Uwe Kleine-König <[email protected]>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Acked-by: Richard Weinberger <[email protected]>

Feel free to carry it though the i2c tree.

Thanks,
//richard