Hi Liam,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/built-in.o: In function `pm8607_write_device':
88pm8607.c:(.text+0xd1359): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `pm8607_read_device':
88pm8607.c:(.text+0xd13ab): undefined reference to `i2c_master_send'
88pm8607.c:(.text+0xd13cc): undefined reference to `i2c_master_recv'
drivers/built-in.o: In function `pm8607_init':
88pm8607.c:(.init.text+0xaa22): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `pm8607_probe':
88pm8607.c:(.devinit.text+0x50fb): undefined reference to `mfd_add_devices'
drivers/built-in.o: In function `pm8607_exit':
88pm8607.c:(.exit.text+0x5de): undefined reference to `i2c_del_driver'
drivers/built-in.o: In function `pm8607_remove':
88pm8607.c:(.devexit.text+0x1cc): undefined reference to `mfd_remove_devices'
Caused by commit 258e3427f83a573d738344c2f5499da5e026e1df ("regulator:
add 88PM8607 PMIC driver"). This is the same driver that has caused the
mfd tree to fail in the same way since next-20091006. I have used the
version of the voltage tree from next-20091009 for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
On Sun, Oct 11, 2009 at 10:26 PM, Stephen Rothwell <[email protected]> wrote:
> Hi Liam,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/built-in.o: In function `pm8607_write_device':
> 88pm8607.c:(.text+0xd1359): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `pm8607_read_device':
> 88pm8607.c:(.text+0xd13ab): undefined reference to `i2c_master_send'
> 88pm8607.c:(.text+0xd13cc): undefined reference to `i2c_master_recv'
> drivers/built-in.o: In function `pm8607_init':
> 88pm8607.c:(.init.text+0xaa22): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `pm8607_probe':
> 88pm8607.c:(.devinit.text+0x50fb): undefined reference to `mfd_add_devices'
> drivers/built-in.o: In function `pm8607_exit':
> 88pm8607.c:(.exit.text+0x5de): undefined reference to `i2c_del_driver'
> drivers/built-in.o: In function `pm8607_remove':
> 88pm8607.c:(.devexit.text+0x1cc): undefined reference to `mfd_remove_devices'
>
> Caused by commit 258e3427f83a573d738344c2f5499da5e026e1df ("regulator:
> add 88PM8607 PMIC driver"). ?This is the same driver that has caused the
> mfd tree to fail in the same way since next-20091006. ?I have used the
> version of the voltage tree from next-20091009 for today.
>
> --
> Cheers,
> Stephen Rothwell ? ? ? ? ? ? ? ? ? [email protected]
> http://www.canb.auug.org.au/~sfr/
>
Hi Samuel & Liam,
Please help review and merge this fix patch. I'm sorry for inconvience.
Stephen,
Thanks for your check.
>From b7d3707263598c4c6671ac592eaaf13535a7b96a Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <[email protected]>
Date: Tue, 6 Oct 2009 08:08:37 -0400
Subject: [PATCH] mfd: fix the dependancy issue on 88PM8607
88PM8607 depends on I2C and MFD_CORE. Since 88PM8607 is built-in
kernel, it also requires that I2C and MFD_CORE are built-in
kernel also.
Signed-off-by: Haojian Zhuang <[email protected]>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index fbe684b..00064e2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -307,7 +307,7 @@ config EZX_PCAP
config MFD_88PM8607
bool "Support Marvell 88PM8607"
- depends on I2C
+ depends on I2C=y
select MFD_CORE
help
This supports for Marvell 88PM8607 Power Management IC. This includes
--
1.5.6.5
Best Regards
Haojian
On Sun, Oct 11, 2009 at 10:50:54PM -0400, Haojian Zhuang wrote:
> Hi Samuel & Liam,
> Please help review and merge this fix patch. I'm sorry for inconvience.
This is waiting for Samuel - it should go via the MFD tree. I've CCed
in Samuel's current e-mail address on the off-chance that that helps.
On Mon, Oct 12, 2009 at 01:57:07PM +0100, Mark Brown wrote:
> On Sun, Oct 11, 2009 at 10:50:54PM -0400, Haojian Zhuang wrote:
>
> > Hi Samuel & Liam,
>
> > Please help review and merge this fix patch. I'm sorry for inconvience.
>
> This is waiting for Samuel - it should go via the MFD tree. I've CCed
> in Samuel's current e-mail address on the off-chance that that helps.
Patch applied and pushed. Sorry for the delay, I wasnt cc'ed at first.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/