2019-11-26 13:21:58

by Mihail Atanassov

Subject: [PATCH 22/30] drm/exynos: mic: Use drm_bridge_init()

No functional change: no logic depends on driver_private being NULL, so
it's safe to set it earlier in exynos_mic_probe.

Signed-off-by: Mihail Atanassov <[email protected]>
---
drivers/gpu/drm/exynos/exynos_drm_mic.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index f41d75923557..caad348a5646 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -309,10 +309,6 @@ static const struct drm_bridge_funcs mic_bridge_funcs = {
static int exynos_mic_bind(struct device *dev, struct device *master,
void *data)
{
- struct exynos_mic *mic = dev_get_drvdata(dev);
-
- mic->bridge.driver_private = mic;
-
return 0;
}

@@ -422,9 +418,7 @@ static int exynos_mic_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, mic);

- mic->bridge.funcs = &mic_bridge_funcs;
- mic->bridge.of_node = dev->of_node;
-
+ drm_bridge_init(&mic->bridge, dev, &mic_bridge_funcs, NULL, mic);
drm_bridge_add(&mic->bridge);

pm_runtime_enable(dev);
--
2.23.0

2019-12-03 04:53:54

by 대인기/Tizen Platform Lab(SR)/삼성전자

Subject: Re: [PATCH 22/30] drm/exynos: mic: Use drm_bridge_init()

19. 11. 26. 오후 10:16에 Mihail Atanassov 이(가) 쓴 글:
> No functional change: no logic depends on driver_private being NULL, so
> it's safe to set it earlier in exynos_mic_probe.
Acked-by: Inki Dae <[email protected]>

And tested this patch on TM2 and TM2E boards.
Tested-by: Inki Dae <[email protected]>

Thanks,
Inki Dae

>
> Signed-off-by: Mihail Atanassov <[email protected]>
> ---
> drivers/gpu/drm/exynos/exynos_drm_mic.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index f41d75923557..caad348a5646 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -309,10 +309,6 @@ static const struct drm_bridge_funcs mic_bridge_funcs = {
> static int exynos_mic_bind(struct device *dev, struct device *master,
> void *data)
> {
> - struct exynos_mic *mic = dev_get_drvdata(dev);
> -
> - mic->bridge.driver_private = mic;
> -
> return 0;
> }
>
> @@ -422,9 +418,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, mic);
>
> - mic->bridge.funcs = &mic_bridge_funcs;
> - mic->bridge.of_node = dev->of_node;
> -
> + drm_bridge_init(&mic->bridge, dev, &mic_bridge_funcs, NULL, mic);
> drm_bridge_add(&mic->bridge);
>
> pm_runtime_enable(dev);
>