This patch set is made based on kernel 3.15.0-rc8.
It's aimed to re-architecture the cyapa driver to support
old gen3 trackpad device and new gen5 trackpad device in one
cyapa driver for easily productions support based on
customers' requirements, and add sysfs functions and interfaces
supported that required by users and customers.
Because the earlier gen3 and the latest gen5 trackpad devies using
two different chipsets, and have different protocol and interfaces.
If supported these two trackpad devices in two different drivers, then
it will be difficult to manage productions and later firmware updates.
it will cause customer don't know which one to use and update
because these two trackpad devices have been used and integrated
in same one productions at a time, so must to support these two trackpad
devices in same on driver.
The new architecture is made of:
cyapa.c - the core of the architecture, supply interfaces and
functions to system and read trackpad devices.
cyapa_gen3.c - functions supported for gen3 trackpad devices,
cyapa_gen5.c - functions supported for gen5 trackpad devices.
Beside this introduction patch, it has 14 patches listed as below.
For these patches each one is patched based on previous one.
patch 1/14: re-architecture cyapa driver with core functions,
and applying the device detecting function in async thread to speed
up system boot time.
patch 2/14: add cyapa driver power management interfaces supported.
patch 3/14: add cyapa driver runtime power management interfaces supported.
patch 4/14: add cyapa key function interfaces in sysfs system.
Including read firmware version, get production ID, read baseline,
re-calibrate trackpad baselines and do trackpad firmware update.
patch 5/14: add read firmware image and read raw trackpad device'
sensors' raw data interface in debugfs system.
patch 6/14: add gen3 trackpad device basic functions supported.
patch 7/14: add gen3 trackpad device firmware update function supported.
patch 8/14: add gen3 trackpad device report baseline and do force
re-calibrate functions supported.
patch 9/14: add gen3 trackpad device read firmware image function supported.
patch 10/14: add gen5 trackpad device basic functions supported.
patch 11/14: add gen5 trackpad device firmware update function supported.
patch 12/14: add gen5 trackpad device report baseline and do force
re-calibrate functions supported.
patch 13/14: add gen5 trackpad device read firmware image and report
sensors' raw data values functions supported.
patch 14/14: add function to monitor LID close event to off trackpad device.
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
Hi Dudley,
I tried to apply your patchset today, but was not successful: it seems
like tabs have been replaced by spaces, and there's a Cypress
signature and a winmail.dat file added to every email, making it
impossible to apply your patches directly.
I've tried to rule out errors on my end. I checked with
http://marc.info/?l=linux-input&m=140203994303131&q=raw that the
original email indeed has all tabs replaced with spaces.
Can you fix your email setup so that these things don't happen - there
is some documentation in Documentation/SubmittingPatches and
Documentation/email-clients.txt - and send the patches again?
Alternatively, maybe you could at least send the patches as
attachments (as output by git format-patch), so that your email system
doesn't mess with them. That's probably not the preferred solution for
the general lkml audience, but would work as a short-term solution for
me.
If I'm mistaken here and someone else was able to apply the patches
successfully, please point me in the right direction.
Thanks,
Patrik
Hi Patrik,
Thanks for your feedback, I'm sorry for the mistake and inconvenience.
Attached are the patches files, I sent it firstly.
I will fix this issue later.
Thanks,
Dudley
-----Original Message-----
From: Patrik Fimml [mailto:[email protected]]
Sent: Saturday, June 28, 2014 7:50 AM
To: Dudley Du
Cc: Dmitry Torokhov; Rafael J. Wysocki; Alan Stern; Benson Leung; Lily Rui; Daniel Kurtz; [email protected]; [email protected]
Subject: Re: [PATCH v2 0/14] input: cyapa: re-architecture driver to support multi-trackpads in one driver
Hi Dudley,
I tried to apply your patchset today, but was not successful: it seems like tabs have been replaced by spaces, and there's a Cypress signature and a winmail.dat file added to every email, making it impossible to apply your patches directly.
I've tried to rule out errors on my end. I checked with http://marc.info/?l=linux-input&m=140203994303131&q=raw that the original email indeed has all tabs replaced with spaces.
Can you fix your email setup so that these things don't happen - there is some documentation in Documentation/SubmittingPatches and Documentation/email-clients.txt - and send the patches again?
Alternatively, maybe you could at least send the patches as attachments (as output by git format-patch), so that your email system doesn't mess with them. That's probably not the preferred solution for the general lkml audience, but would work as a short-term solution for me.
If I'm mistaken here and someone else was able to apply the patches successfully, please point me in the right direction.
Thanks,
Patrik
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
Hi All,
Sorry for the disturb again.
The 14 caypa V2 patches I re-sent through 14:41 to 14:45 at 2014/6/30 still have some of them corrupted by the mail server.
Please ignore them. I will try to fix them.
Thanks,
Dudley
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
Hi Dudley,
On Mon, Jun 30, 2014 at 05:43:06AM +0000, Dudley Du wrote:
> Attached are the patches files, I sent it firstly.
Thanks for the response, I was able to apply the patches now.
The attached files lack headers and commit messages though, so I don't have
fine-grained history in my git tree for convenient later review. The file names
suggest to me that you might just have copy-and-pasted the patches from
somewhere.
It would be great if you could attach them again in the format produced by "git
format-patch", with no further modifications done by hand. (If you feel the
need to do modifications, you should modify the actual commits e.g. with "git
rebase -i" before using format-patch.) Others can then simply import your
changes - including commit messages - into their tree with "git am".
Thanks,
Patrik
Hi Patrik,
Thanks for your patient and detail instructions.
I will try to fix these issues and resubmit again.
Thanks,
Dudley
> -----Original Message-----
> From: Patrik Fimml [mailto:[email protected]]
> Sent: Tuesday, July 01, 2014 4:00 AM
> To: Dudley Du
> Cc: Dmitry Torokhov; Rafael J. Wysocki; Alan Stern; Benson Leung; Lily Rui;
> Daniel Kurtz; [email protected]; [email protected]
> Subject: Re: [PATCH v2 0/14] input: cyapa: re-architecture driver to support
> multi-trackpads in one driver
>
> Hi Dudley,
>
> On Mon, Jun 30, 2014 at 05:43:06AM +0000, Dudley Du wrote:
> > Attached are the patches files, I sent it firstly.
>
> Thanks for the response, I was able to apply the patches now.
>
> The attached files lack headers and commit messages though, so I don't have
> fine-grained history in my git tree for convenient later review. The file
> names
> suggest to me that you might just have copy-and-pasted the patches from
> somewhere.
>
> It would be great if you could attach them again in the format produced by
> "git
> format-patch", with no further modifications done by hand. (If you feel the
> need to do modifications, you should modify the actual commits e.g. with "git
> rebase -i" before using format-patch.) Others can then simply import your
> changes - including commit messages - into their tree with "git am".
>
> Thanks,
> Patrik
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
Hi Patrik, All,
Attached files are the non-modified patches with headers and commit messages.
I'm sorry still cannot submit clean patches yet.
I was trying to fix the auto added company's signature and a winmail.dat file issue with our IT. But cannot fix yet.
I will try to resubmit this patches as v2.1 when fix the email issues.
Thanks,
Dudley
> -----Original Message-----
> From: Patrik Fimml [mailto:[email protected]]
> Sent: Tuesday, July 01, 2014 4:00 AM
> To: Dudley Du
> Cc: Dmitry Torokhov; Rafael J. Wysocki; Alan Stern; Benson Leung; Lily Rui;
> Daniel Kurtz; [email protected]; [email protected]
> Subject: Re: [PATCH v2 0/14] input: cyapa: re-architecture driver to support
> multi-trackpads in one driver
>
> Hi Dudley,
>
> On Mon, Jun 30, 2014 at 05:43:06AM +0000, Dudley Du wrote:
> > Attached are the patches files, I sent it firstly.
>
> Thanks for the response, I was able to apply the patches now.
>
> The attached files lack headers and commit messages though, so I don't have
> fine-grained history in my git tree for convenient later review. The file
> names
> suggest to me that you might just have copy-and-pasted the patches from
> somewhere.
>
> It would be great if you could attach them again in the format produced by
> "git
> format-patch", with no further modifications done by hand. (If you feel the
> need to do modifications, you should modify the actual commits e.g. with "git
> rebase -i" before using format-patch.) Others can then simply import your
> changes - including commit messages - into their tree with "git am".
>
> Thanks,
> Patrik
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.