2022-03-01 14:51:23

by Brijesh Singh

Subject: Re: [PATCH Part2 v5 14/45] crypto: ccp: Handle the legacy TMR allocation when SNP is enabled

Hi Alper,

On 2/25/22 12:03, Alper Gun wrote:

>>
>> - free_pages((unsigned long)sev_es_tmr,
>> - get_order(SEV_ES_TMR_SIZE));
>> + __snp_free_firmware_pages(virt_to_page(sev_es_tmr),
>> + get_order(sev_es_tmr_size),
>> + false);
> Shouldn't there be a check here for snp_inited before calling rmpupdate.
> TMR page can exist even if the SNP is not supported.
>

Yes, I have this fix in my WIP branch and will be included in the v6.

thanks