2021-11-18 19:37:27

by Christophe JAILLET

Subject: [PATCH] net: ipa: Use 'for_each_clear_bit' when possible

Use 'for_each_clear_bit()' instead of hand writing it. It is much less
version.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/ipa/ipa_mem.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c
index 4337b0920d3d..1e9eae208e44 100644
--- a/drivers/net/ipa/ipa_mem.c
+++ b/drivers/net/ipa/ipa_mem.c
@@ -266,9 +266,7 @@ static bool ipa_mem_valid(struct ipa *ipa, const struct ipa_mem_data *mem_data)
}

/* Now see if any required regions are not defined */
- for (mem_id = find_first_zero_bit(regions, IPA_MEM_COUNT);
- mem_id < IPA_MEM_COUNT;
- mem_id = find_next_zero_bit(regions, IPA_MEM_COUNT, mem_id + 1)) {
+ for_each_clear_bit(mem_id, regions, IPA_MEM_COUNT) {
if (ipa_mem_id_required(ipa, mem_id))
dev_err(dev, "required memory region %u missing\n",
mem_id);
--
2.30.2

2021-11-19 11:50:34

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: ipa: Use 'for_each_clear_bit' when possible

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Thu, 18 Nov 2021 20:37:15 +0100 you wrote:
> Use 'for_each_clear_bit()' instead of hand writing it. It is much less
> version.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/net/ipa/ipa_mem.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
- net: ipa: Use 'for_each_clear_bit' when possible
https://git.kernel.org/netdev/net-next/c/a6366b13c165

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2021-11-19 13:14:52

by Alex Elder

Subject: Re: [PATCH] net: ipa: Use 'for_each_clear_bit' when possible

On 11/18/21 1:37 PM, Christophe JAILLET wrote:
> Use 'for_each_clear_bit()' instead of hand writing it. It is much less
> version.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

I know this just got committed, but thanks, this
is a good improvement.

-Alex

> ---
> drivers/net/ipa/ipa_mem.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c
> index 4337b0920d3d..1e9eae208e44 100644
> --- a/drivers/net/ipa/ipa_mem.c
> +++ b/drivers/net/ipa/ipa_mem.c
> @@ -266,9 +266,7 @@ static bool ipa_mem_valid(struct ipa *ipa, const struct ipa_mem_data *mem_data)
> }
>
> /* Now see if any required regions are not defined */
> - for (mem_id = find_first_zero_bit(regions, IPA_MEM_COUNT);
> - mem_id < IPA_MEM_COUNT;
> - mem_id = find_next_zero_bit(regions, IPA_MEM_COUNT, mem_id + 1)) {
> + for_each_clear_bit(mem_id, regions, IPA_MEM_COUNT) {
> if (ipa_mem_id_required(ipa, mem_id))
> dev_err(dev, "required memory region %u missing\n",
> mem_id);
>