2007-02-28 22:27:41

by Chuck Ebbert

[permalink] [raw]
Subject: PID entries in /proc sorted by number, not start time in 2.6.19

Starting with kernel 2.6.19, the process directories in
/proc are sorted by number. They were sorted by process
start time in 2.6.18 and earlier. This makes the output
of procps come out in that order too, pissing off users
who are used to the old way.

To reproduce:
1. Wrap your PID numbers.
2. Do ls -fl /proc
3. Look at output of ps command.

Compare 2.6.18 to 2.6.19.

See also:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230227


2007-02-28 23:40:00

by Eric W. Biederman

[permalink] [raw]
Subject: Re: PID entries in /proc sorted by number, not start time in 2.6.19

Chuck Ebbert <[email protected]> writes:

> Starting with kernel 2.6.19, the process directories in
> /proc are sorted by number. They were sorted by process
> start time in 2.6.18 and earlier. This makes the output
> of procps come out in that order too, pissing off users
> who are used to the old way.
>
> To reproduce:
> 1. Wrap your PID numbers.
> 2. Do ls -fl /proc
> 3. Look at output of ps command.
>
> Compare 2.6.18 to 2.6.19.
>
> See also:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230227

Apologies, but this was a bug fix for a more serious issue. The code
to report the directory entries by start time was fundamentally broken.
In particular the sequence:
opendir
readdir
readdir
readdir
....
closedir

can miss processes that exist for the entire duration of that
sequence. Which is non-posix, non-intuitive, and has no reasonable
work around.

The sorting by pid happened as a side effect of finding a stable token
we can come back to so we can at least guarantee normal readdir
semantics. That objects that exist for the entire readdir are
guaranteed to be displayed. That objects that come into existence or
are deleted during the readdir may be missed. That isn't perfect but
it is a useable semantic.

Eric

2007-03-01 01:16:28

by Albert Cahalan

[permalink] [raw]
Subject: Re: PID entries in /proc sorted by number, not start time in 2.6.19

On 2/28/07, Eric W. Biederman <[email protected]> wrote:
> Chuck Ebbert <[email protected]> writes:
>
> > Starting with kernel 2.6.19, the process directories in
> > /proc are sorted by number. They were sorted by process
> > start time in 2.6.18 and earlier. This makes the output
> > of procps come out in that order too, pissing off users
> > who are used to the old way.

ps --sort=start_time

I've always just assumed the order to be random.