Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
TPS6598x is cold-reset during unconditionally on probe failures by
sending "GAID" sequence.
The probe can fail initially because USB0 remote-endpoint may not be
probed yet, which defines the usb-role-switch property.
Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/
Signed-off-by: Jai Luthra <[email protected]>
---
Boot-logs with this patch applied:
https://gist.github.com/jailuthra/b66d5722090ce1fbc2886986e53640f7
---
drivers/usb/typec/tipd/core.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index a956eb976906..8ba2aa05db51 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -1223,11 +1223,16 @@ static int cd321x_reset(struct tps6598x *tps)
return 0;
}
-static int tps6598x_reset(struct tps6598x *tps)
+static int tps25750_reset(struct tps6598x *tps)
{
return tps6598x_exec_cmd_tmo(tps, "GAID", 0, NULL, 0, NULL, 2000, 0);
}
+static int tps6598x_reset(struct tps6598x *tps)
+{
+ return 0;
+}
+
static int
tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
{
@@ -1545,7 +1550,7 @@ static const struct tipd_data tps25750_data = {
.trace_status = trace_tps25750_status,
.apply_patch = tps25750_apply_patch,
.init = tps25750_init,
- .reset = tps6598x_reset,
+ .reset = tps25750_reset,
};
static const struct of_device_id tps6598x_of_match[] = {
---
base-commit: e2425464bc87159274879ab30f9d4fe624b9fcd2
change-id: 20240105-next-tps-fix-904ed92bc1cc
Best regards,
--
Jai Luthra <[email protected]>
Hello!
On 1/5/24 12:06 PM, Jai Luthra wrote:
> Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
> TPS6598x is cold-reset during unconditionally on probe failures by
Hm, I can't parse this. During what?
> sending "GAID" sequence.
>
> The probe can fail initially because USB0 remote-endpoint may not be
> probed yet, which defines the usb-role-switch property.
>
> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
> Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/
> Signed-off-by: Jai Luthra <[email protected]>
[...]
MBR, Sergey
On Fri, Jan 05, 2024 at 12:15:36PM +0300, Sergey Shtylyov wrote:
> Hello!
>
> On 1/5/24 12:06 PM, Jai Luthra wrote:
>
> > Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
> > TPS6598x is cold-reset during unconditionally on probe failures by
>
> Hm, I can't parse this. During what?
See the thread that is listed here:
> > Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/
thanks,
greg k-h
On 1/5/24 12:34 PM, Greg Kroah-Hartman wrote:
[...]
>>> Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
>>> TPS6598x is cold-reset during unconditionally on probe failures by
>>
>> Hm, I can't parse this. During what?
>
> See the thread that is listed here:
>
>>> Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/
I don't see how it helps with what seems to be a grammar issue...
Either a noun should follow "during" or that "during" just shouldn't
be there...
> thanks,
>
> greg k-h
MBR, Sergey
On Jan 05, 2024 at 12:15:36 +0300, Sergey Shtylyov wrote:
> Hello!
>
> On 1/5/24 12:06 PM, Jai Luthra wrote:
>
> > Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
> > TPS6598x is cold-reset during unconditionally on probe failures by
>
> Hm, I can't parse this. During what?
My bad
s/cold-reset during unconditionally/cold-reset unconditionally/
>
> > sending "GAID" sequence.
> >
> > The probe can fail initially because USB0 remote-endpoint may not be
> > probed yet, which defines the usb-role-switch property.
> >
> > Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
> > Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/
> > Signed-off-by: Jai Luthra <[email protected]>
> [...]
>
> MBR, Sergey
>
--
Thanks,
Jai
GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145
On 05/01/2024 11:06, Jai Luthra wrote:
> Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
> TPS6598x is cold-reset during unconditionally on probe failures by
> sending "GAID" sequence.
>
> The probe can fail initially because USB0 remote-endpoint may not be
> probed yet, which defines the usb-role-switch property.
>
> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
> Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/
> Signed-off-by: Jai Luthra <[email protected]>
Reviewed-by: Roger Quadros <[email protected]>
On Fri, Jan 05, 2024 at 02:36:54PM +0530, Jai Luthra wrote:
> Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
> TPS6598x is cold-reset during unconditionally on probe failures by
> sending "GAID" sequence.
>
> The probe can fail initially because USB0 remote-endpoint may not be
> probed yet, which defines the usb-role-switch property.
>
> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
> Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/
> Signed-off-by: Jai Luthra <[email protected]>
Reviewed-by: Heikki Krogerus <[email protected]>
> ---
> Boot-logs with this patch applied:
> https://gist.github.com/jailuthra/b66d5722090ce1fbc2886986e53640f7
> ---
> drivers/usb/typec/tipd/core.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index a956eb976906..8ba2aa05db51 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1223,11 +1223,16 @@ static int cd321x_reset(struct tps6598x *tps)
> return 0;
> }
>
> -static int tps6598x_reset(struct tps6598x *tps)
> +static int tps25750_reset(struct tps6598x *tps)
> {
> return tps6598x_exec_cmd_tmo(tps, "GAID", 0, NULL, 0, NULL, 2000, 0);
> }
>
> +static int tps6598x_reset(struct tps6598x *tps)
> +{
> + return 0;
> +}
> +
> static int
> tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
> {
> @@ -1545,7 +1550,7 @@ static const struct tipd_data tps25750_data = {
> .trace_status = trace_tps25750_status,
> .apply_patch = tps25750_apply_patch,
> .init = tps25750_init,
> - .reset = tps6598x_reset,
> + .reset = tps25750_reset,
> };
>
> static const struct of_device_id tps6598x_of_match[] = {
>
> ---
> base-commit: e2425464bc87159274879ab30f9d4fe624b9fcd2
> change-id: 20240105-next-tps-fix-904ed92bc1cc
>
> Best regards,
> --
> Jai Luthra <[email protected]>
--
heikki