2017-12-21 18:32:14

by Stefan Brüns

Subject: [PATCH v2 6/7] iio: adc: ina2xx: Align timestamp with conversion ready flag

As the timestamp is no longer (ab-)used to measure the function run time,
it can be taken at the correct time, i.e. when the conversion has finished.

Signed-off-by: Stefan Brüns <[email protected]>
---

Changes in v2: None

drivers/iio/adc/ina2xx-adc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
index 415e53b5c0a6..b7407ac91b59 100644
--- a/drivers/iio/adc/ina2xx-adc.c
+++ b/drivers/iio/adc/ina2xx-adc.c
@@ -706,8 +706,6 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
s64 time;
unsigned int alert;

- time = iio_get_time_ns(indio_dev);
-
/*
* Because the timer thread and the chip conversion clock
* are asynchronous, the period difference will eventually
@@ -736,6 +734,8 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)

} while (!alert);

+ time = iio_get_time_ns(indio_dev);
+
/*
* Single register reads: bulk_read will not work with ina226/219
* as there is no auto-increment of the register pointer.
--
2.15.1

2017-12-29 17:49:11

by Jonathan Cameron

Subject: Re: [PATCH v2 6/7] iio: adc: ina2xx: Align timestamp with conversion ready flag

On Thu, 21 Dec 2017 19:31:37 +0100
Stefan Brüns <[email protected]> wrote:

> As the timestamp is no longer (ab-)used to measure the function run time,
> it can be taken at the correct time, i.e. when the conversion has finished.
>
> Signed-off-by: Stefan Brüns <[email protected]>
Applied.

Thanks,

Jonathan

> ---
>
> Changes in v2: None
>
> drivers/iio/adc/ina2xx-adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index 415e53b5c0a6..b7407ac91b59 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -706,8 +706,6 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
> s64 time;
> unsigned int alert;
>
> - time = iio_get_time_ns(indio_dev);
> -
> /*
> * Because the timer thread and the chip conversion clock
> * are asynchronous, the period difference will eventually
> @@ -736,6 +734,8 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
>
> } while (!alert);
>
> + time = iio_get_time_ns(indio_dev);
> +
> /*
> * Single register reads: bulk_read will not work with ina226/219
> * as there is no auto-increment of the register pointer.